Summary: | No anti-aliasing option for Continuous Selection Tool | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Tiar <tamtamy.tymona> |
Component: | Tools/Selection | Assignee: | Tiar <tamtamy.tymona> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla |
Priority: | NOR | ||
Version: | 4.2.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/0a2ed07da31e22bcc2691d06e8247e666b8a8d5f | Version Fixed In: | |
Sentry Crash Report: |
Description
Tiar
2019-06-15 11:59:22 UTC
Git commit 080e298f54a9d8524b60e213fafe6bd128a86e16 by Agata Cacko. Committed on 19/06/2019 at 09:40. Pushed by tymond into branch 'master'. Fix Contiguous sel. tool no checkbox for AA Before this commit there was an issue when other selection tools had vector selections mode checked. In vector selections mode, there is no anti-aliasing, so the checkbox is hidden. The problem is, similar color selection tool and contiguous color selection tool are pixel-only, so they don't care about vector selections mode being checked. Moreover similar color selection tool doesn't use AA checkbox. This commit ensures that checkbox is visible always on contiguous selection tool, never on similar color selection tool and only in pixel selection mode in other tools. M +11 -0 libs/ui/tool/kis_tool_select_base.h M +6 -0 libs/ui/widgets/kis_selection_options.cc M +1 -0 libs/ui/widgets/kis_selection_options.h M +0 -1 plugins/tools/selectiontools/kis_tool_select_contiguous.cc M +2 -0 plugins/tools/selectiontools/kis_tool_select_contiguous.h M +7 -1 plugins/tools/selectiontools/kis_tool_select_similar.cc M +1 -0 plugins/tools/selectiontools/kis_tool_select_similar.h https://invent.kde.org/kde/krita/commit/080e298f54a9d8524b60e213fafe6bd128a86e16 Git commit 0a2ed07da31e22bcc2691d06e8247e666b8a8d5f by Boudewijn Rempt, on behalf of Agata Cacko. Committed on 20/06/2019 at 10:32. Pushed by rempt into branch 'krita/4.2'. Fix Contiguous sel. tool no checkbox for AA Before this commit there was an issue when other selection tools had vector selections mode checked. In vector selections mode, there is no anti-aliasing, so the checkbox is hidden. The problem is, similar color selection tool and contiguous color selection tool are pixel-only, so they don't care about vector selections mode being checked. Moreover similar color selection tool doesn't use AA checkbox. This commit ensures that checkbox is visible always on contiguous selection tool, never on similar color selection tool and only in pixel selection mode in other tools. M +11 -0 libs/ui/tool/kis_tool_select_base.h M +6 -0 libs/ui/widgets/kis_selection_options.cc M +1 -0 libs/ui/widgets/kis_selection_options.h M +0 -1 plugins/tools/selectiontools/kis_tool_select_contiguous.cc M +2 -0 plugins/tools/selectiontools/kis_tool_select_contiguous.h M +7 -1 plugins/tools/selectiontools/kis_tool_select_similar.cc M +1 -0 plugins/tools/selectiontools/kis_tool_select_similar.h https://invent.kde.org/kde/krita/commit/0a2ed07da31e22bcc2691d06e8247e666b8a8d5f |