| Summary: | Too difficult to click on the playback slider to choose a new playback position | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/elisa/67565a465488be90f2d59aac2fc72399046b6b24 | Version Fixed In: | |
|
Description
Nate Graham
2019-06-14 18:42:35 UTC
Here's a patch: https://phabricator.kde.org/D22951 Git commit 67565a465488be90f2d59aac2fc72399046b6b24 by Nate Graham. Committed on 06/08/2019 at 20:38. Pushed by ngraham into branch 'master'. Make it easier to click on a new position for the playback and volume sliders Summary: Because Elisa uses customized visuals for its sliders, various nice features of the default implementation need to be re-implemented. One example is mouse wheel/scroll handling, which was done in D22332. Another example is expanded click areas, which is the target of this patch. This patch makes the effective click targets fill the entire available space. This makes it vastly easier to move the slider to a new position with a click. Test Plan: - It's 1000% easier to click to get a new slider position - Still looks good with Breeze light and dark color schemes Reviewers: #elisa, #vdg, mgallien, astippich Reviewed By: #elisa, mgallien Differential Revision: https://phabricator.kde.org/D22951 M +43 -17 src/qml/MediaPlayerControl.qml https://commits.kde.org/elisa/67565a465488be90f2d59aac2fc72399046b6b24 |