Bug 408680

Summary: Provide feedback when search options are disabled in Dolphin
Product: [Applications] dolphin Reporter: J.Novo <jgc.novo>
Component: searchAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: bugseforuns, mail, nate, sven.burmeister
Priority: NOR Keywords: junior-jobs, usability
Version: 19.04.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/dolphin/c144701c28aa02a1fd9e1a24460ae9e5178ed069 Version Fixed In: 19.11.80
Sentry Crash Report:

Description J.Novo 2019-06-14 09:22:34 UTC 
SUMMARY

Trying to search an unindexed folder makes the search options in dolphin stay disabled but is not clear what is going on.

Dolphin could:

. Show a informational message letting the user know why the options are disabled.
. Hide the "more options" item when is not available.
. Offer other search solutions in the place of the disabled options.


STEPS TO REPRODUCE

1. Open dolphin and go to root.
2. Open search and try to change "more options".
3. All is disabled.


Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.16.80
KDE Frameworks Version: 5.60.0
Qt Version: 5.12.3
Kernel Version: 4.18.0-21-generic
OS Type: 64-bit
Comment 1 Julian Steinmann 2019-06-14 10:40:24 UTC 
*** Bug 279349 has been marked as a duplicate of this bug. ***
Comment 2 Julian Steinmann 2019-06-14 10:41:19 UTC 
Related to https://bugs.kde.org/show_bug.cgi?id=318580.
Comment 3 Elvis Angelaccio 2019-10-13 15:25:43 UTC 
Git commit c144701c28aa02a1fd9e1a24460ae9e5178ed069 by Elvis Angelaccio, on behalf of Ismael Asensio.
Committed on 13/10/2019 at 15:22.
Pushed by elvisangelaccio into branch 'master'.

Hide search extra options when not available

Summary:
Hide the search extra options when they are not available, because the current location is not indexed or Baloo is not enabled.
The button is disabled and shows a tooltip to provide feedback of why it's not available.
Depends on D24478

{F7531893}
Related: bug 318580, bug 396898
FIXED-IN: 19.11.80

Test Plan:
 - `Ctrl-F` on a non-indexed location
 - `balooctl disable` and `Ctrl-F` on an indexed location

On both cases the extra options are not shown, the button is disabled and the reason is shown in the tooltip
The user selection is remembered between indexed locations.

Reviewers: #dolphin, elvisangelaccio, meven, ngraham

Reviewed By: meven

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D24446

M  +43   -12   src/search/dolphinsearchbox.cpp
M  +1    -0    src/search/dolphinsearchbox.h

https://commits.kde.org/dolphin/c144701c28aa02a1fd9e1a24460ae9e5178ed069