| Summary: | KToggleToolBarAction constructor using toolbar name does nothing | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kxmlgui | Reporter: | Simone Gaiarin <simgunz> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | aspotashev, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Simone Gaiarin
2019-06-13 19:24:42 UTC
The documentation says "This can be either the name of a toolbar in an xml ui file, or a toolbar programmatically created with that name." I have no idea if it is really expected to be working with not-yet-created toobars. I guess it would have to globally watch all newly created objects to check if a toolbar with this name was created. If the toolbar already exists, I suggest to use the other constructor. To be more clear, what I am trying to achieve is to add an action to toggle a toolbar created with XMLGUI. The problem is that I have no idea on how to retrieve the XMLGUI toolbar instance, in order to use the other constructor. I am not even sure that it is already created while I am trying to set up the actions. Any suggestions/reference on how to do this? I thought that the first constructor was intended to be used with XMLGUI, but apparently it is not. Looking at the code, I am not even sure that the first constructor will work with programmatically created named toolbars. No, it doesn't work. As you wrote, it just stores the name, but never connects to any toolbar with that name. If the toolbar is already created, use QObject::findChild<KToolBar *>(name) on the window. I have to find a checkout of kdelibs4 to check if this is a porting regression, or if it never worked. As is, the code is useless. I traced commits back to 2006. The 'toolBarName' feature never worked; there was no code to handle it. I am unsure if we should try to implement it (see difficulties described in comment #1), or just remove/deprecate the never working constructor. In my situation I managed to workaround the problem as explained in the comments of https://phabricator.kde.org/D15580. The code would have been neater if I could have used constructuor 1: in this way I could have defined the action together with the other actions in pageview.cpp instead of defining it separately in shell.cpp. Probably deprecating the first constructor is the most straightforward solution. According to my superficial google searches KToggleToolBarAction does not seem to be used a lot, at least not many results popped up. |