Summary: | Konsole crash when coping highlighted text | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | J.Novo <jgc.novo> |
Component: | copy-paste | Assignee: | David Hallas <david> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | david, nate, rahulc93, yanp.bugz |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/konsole/commit/2562c3a003f6359fe2b5afae9ab5b1c318bf35ad | Version Fixed In: | 19.08.0 |
Description
J.Novo
2019-06-12 08:57:19 UTC
What version of Konsole are you using? A lot has changed recently and I can't reproduce on 19.04 nor master. Version 19.04.2 KDE Frameworks 5.59.0 Qt 5.12.3 (built against 5.12.3) I tried again and seems that is only happening with links like file:// or http://. I can reproduce it like: 1. echo https://kde.org/ 2. edit->find 3. type kde in the search box 4. select kde.org 5. right click and click copy Thanks for the steps to follow - it crashes on 19.04 but not current master (19.08) I'll research git bisect says 7265be97a2e9d84c4e036d426ffb0085710d9361 caused this. https://phabricator.kde.org/D19636 Strange, master doesn't show this issue. It happens on master as well I have pushed a review that fixes this crash: https://phabricator.kde.org/D21849 I have tested quite a bit with this patch and haven't seen any crashes or leaks, but please give it a thorough test as well, just to be sure. I don't want to introduce any other regressions :D And thanks for reporting the issue! Thanks, so far it looks good. I'm not clear on why when searching the links are no longer valid (no open/copy url, email, etc) even when the links are not highlighted. Although not really related to this crash or fix. (In reply to Kurt Hindenburg from comment #7) > Thanks, so far it looks good. > > I'm not clear on why when searching the links are no longer valid (no > open/copy url, email, etc) even when the links are not highlighted. > Although not really related to this crash or fix. Me neither :/ I think in general there are a bit too many raw pointers in this code for my taste :) It would be nice to work towards changing them to more safer alternatives. (In reply to David Hallas from comment #6) > I have pushed a review that fixes this crash: > > https://phabricator.kde.org/D21849 > > I have tested quite a bit with this patch and haven't seen any crashes or > leaks, but please give it a thorough test as well, just to be sure. I don't > want to introduce any other regressions :D > > And thanks for reporting the issue! Works good here. Btw, i noticed the search box is not correctly aligned. When i first open it it is positioned like in the middle, then if you resize the window it changes position to like the top right. Thanks! Git commit 2562c3a003f6359fe2b5afae9ab5b1c318bf35ad by Kurt Hindenburg, on behalf of David Hallas. Committed on 16/06/2019 at 15:35. Pushed by scmsync into branch 'master'. Fixes crash when copying hotspot Summary: Fixes crash when copying hotspot. It is caused by the code would remove any actions from the hotspot after the context menu had executed, but these actions have now been freed because the hotspot is freed (this was done in 7265be97a2e9d84c4e036d426ffb0085710d9361 to fix a memory leak). Test Plan: echo https://kde.org/ edit->find type kde in the search box select kde.org right click and click copy Reviewers: #konsole, hindenburg Subscribers: konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D21849 M +0 -9 src/SessionController.cpp https://commits.kde.org/konsole/2562c3a003f6359fe2b5afae9ab5b1c318bf35ad Git commit 2562c3a003f6359fe2b5afae9ab5b1c318bf35ad by Kurt Hindenburg, on behalf of David Hallas. Committed on 16/06/2019 at 15:35. Pushed by hindenburg into branch 'master'. Fixes crash when copying hotspot Summary: Fixes crash when copying hotspot. It is caused by the code would remove any actions from the hotspot after the context menu had executed, but these actions have now been freed because the hotspot is freed (this was done in 7265be97a2e9d84c4e036d426ffb0085710d9361 to fix a memory leak). Test Plan: echo https://kde.org/ edit->find type kde in the search box select kde.org right click and click copy Reviewers: #konsole, hindenburg Subscribers: konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D21849 M +0 -9 src/SessionController.cpp https://invent.kde.org/kde/konsole/commit/2562c3a003f6359fe2b5afae9ab5b1c318bf35ad High! This issue is hitting me daily, most probably it's dupe of https://bugs.kde.org/show_bug.cgi?id=411183 I am using kubuntu backports ppa, will the fix be released for 19.04? Or how can I get fixed konsole? *** Bug 414748 has been marked as a duplicate of this bug. *** |