Bug 408555

Summary:	Retangular Selection Tool page informs wrong shortcut (J rather than Ctrl + R)
Product:	[Applications] krita	Reporter:	Flávio Monteiro <flaviomonteiro2013>
Component:	Documentation	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ghevan, raghu, tamtamy.tymona
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
URL:	https://docs.krita.org/en/reference_manual/tools/rectangular_select.html#hotkeys-and-stickykeys
Latest Commit:	https://invent.kde.org/websites/docs-krita-org/commit/b6a0a332c5aa184a6b42aa91088b0dc6f3478eb7	Version Fixed In:
Sentry Crash Report:

Description Flávio Monteiro 2019-06-10 23:32:15 UTC

The page in question (https://docs.krita.org/en/reference_manual/tools/rectangular_select.html) says "J selects this tool." when it should be Ctrl+R. 

I suspect this is an accidental copy paste from the Elliptical Selection Tool, might be a good idea to check if the docs are wrong with other tools too.

Tested with both "Default" and "krita_Default" Shortcut Schemes.

Comment 1 Raghavendra kamath 2019-06-11 02:56:16 UTC

Thanks for the report, we will update it soon.

Comment 2 vanyossi 2019-06-11 02:57:10 UTC

Thanks! the Typo has already been fixed in the draft branch for next release. :)

Comment 3 Flávio Monteiro 2020-03-18 06:57:22 UTC

It seems the fix was never merged. Checked it today and the bug is there.

Comment 4 Tiar 2020-03-18 11:08:43 UTC

The bug is fixed for the new version, which is 4.3.0. (master branch on repo).
The documentation site takes the krita/4.2 branch on repo to show the users, so I made a MR for krita/4.2 branch. https://invent.kde.org/websites/docs-krita-org/-/merge_requests/103

Btw it's super easy to make fixes like that if you have a KDE Identity account. You just need to go https://invent.kde.org/websites/docs-krita-org , find the correct file and then press "Edit" and make the fix and follow the green buttons. More detailed instruction here: https://docs.krita.org/en/contributors_manual/krita_manual_readme.html#creating-merge-requests-using-edit-mode

Comment 5 Flávio Monteiro 2020-03-18 21:25:04 UTC

Thanks! I've setup an KDE Inventor/GitLab account and will try to submit a PR next time I find something :P

Comment 6 wolthera 2020-03-24 09:34:00 UTC

Git commit b6a0a332c5aa184a6b42aa91088b0dc6f3478eb7 by Wolthera van Hövell, on behalf of Agata Cacko.
Committed on 24/03/2020 at 09:33.
Pushed by woltherav into branch 'krita/4.2'.

Fix the shortcut for selecting the tool

(It's already fixed on master in 7b97048f50c1b71f10c386b64217e8c6b8102a4a)

M  +1    -1    reference_manual/tools/rectangular_select.rst

https://invent.kde.org/websites/docs-krita-org/commit/b6a0a332c5aa184a6b42aa91088b0dc6f3478eb7