Bug 408544

Summary:	Pressing Escape does not cancel operations correctly.
Product:	[Applications] okular	Reporter:	Laura David Hurka <laura.stern>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	REPORTED ---
Severity:	normal	CC:	aacid, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Laura David Hurka 2019-06-10 18:16:20 UTC

SUMMARY
The event filter (in PageView) handles Escape keystroke events in a strange way.

STEPS TO REPRODUCE
1. Open the Find bar (Ctrl+F).
2. Activate Trim to Selection.
3. Start drawing a trim area.
4. Press Escape

OBSERVED RESULT
Find bar closes and you can’t complete Trim to Selection anymore. (Usually done by releasing the left mouse button.)

EXPECTED RESULT
The trim area is canceled, you can start drawing a new area. Or, Trim to Selection is completely canceled, and you get back to the selected mouse mode.

STEPS TO REPRODUCE
1. Activate Trim to Selection
2. Press Escape

OBSERVED RESULT
Nothing

EXPECTED RESULT
Trim to Selection is canceled, and you get back to the selected mouse mode.

STEPS TO REPRODUCE
1. Open the Find bar.
2. Start drawing a Highlight annotation.
3. Press Escape.

OBSERVED RESULT
Find bar closes, annotation is canceled, annotation toolbar disappears.
Then, you start dragging the document arround. (Bug 398108)

EXPECRED RESULT
Annotation is canceled, you can start a new highlight.

STEPS TO REPRODUCE
1. Select Browse tool (Ctrl+1)
2. Right-click and drag to draw a selection area.
3. Press Escape

OBSERVED RESULT
Drawing selection area is canceled.
Context menu is opened.

EXPECTED RESULT
Drawing selection area is canceled.

STEPS TO REPRODUCE
1. Select Zoom tool, Area Selection tool, or Table Selection Tool.
2. Start drawing an area.
3. Press Escape.

EXPECTED AND OBSERVED RESULT
Drawing the area is canceled, you can start do draw a new zoom area.

SOFTWARE/OS VERSIONS
Okular 1.7.2
KDE Neon 5.15
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0

Comment 1 Albert Astals Cid 2019-06-10 19:52:49 UTC

It seems to me that you should close this bug and open 4 different ones.

Comment 2 Laura David Hurka 2019-06-10 20:01:49 UTC

Thought about that, but all 4 bugs seem to be mostly the same to me. PageView doesn’t care about what should get Escape, but cancels “what it likes to cancel”.

Should I really open 4 different bug reports?

Comment 3 Albert Astals Cid 2019-06-11 18:19:53 UTC

Is 1 line going to fix the 4 issues? If yes, then no, but otherwise they're different issues and deserve different bugs since they'll potentially be fixed at different stages.

Comment 4 Nate Graham 2019-06-13 21:19:11 UTC

+1, different bugs to track different issues is always preferable.