| Summary: | 16px version of draw-text has different meaning from larger sizes | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Nate Graham <nate> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kainz.a |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/okular/2c39981b21d91a01cceab9c391af20f51c5462a8 | Version Fixed In: | 1.8.0 |
| Sentry Crash Report: | |||
| Attachments: | Different icons for the Text Selection tool | ||
Git commit 2c39981b21d91a01cceab9c391af20f51c5462a8 by Noah Davis.
Committed on 06/06/2019 at 18:58.
Pushed by ndavis into branch 'master'.
Change Text Selection icon to edit-select-text
Summary:
The current icon (draw-text) is semantically incorrect. This patch makes the Text Selection tool use the icons added in D21632.
FIXED-IN: 1.8.0
Test Plan: {F6874885, size=full}
Reviewers: #vdg, #okular, ngraham
Reviewed By: #vdg, ngraham
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D21633
M +1 -1 ui/pageview.cpp
https://commits.kde.org/okular/2c39981b21d91a01cceab9c391af20f51c5462a8
|
Created attachment 120633 [details] Different icons for the Text Selection tool The 16px version of draw-text looks like an I-beam about to select some text. The larger version looks like a text box of the type you can create in a drawing program. This semantic difference is a problem because Okular uses it as a "select text" icon, but it on;l looks like that at one size. It's possible to see both versions simultaneously! See attached screenshot. The 16px version should probably look more like the text box version, and we should get a new edit-select-text icon for the text selection metaphor.