Summary: | Can't copy text from information panel | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Pedro Fayolle <pfayolle> |
Component: | panels: information | Assignee: | Gabriel H. <gabrielhuwe> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gabrielhuwe, kde, nate |
Priority: | NOR | Keywords: | junior-jobs, usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | All | ||
Latest Commit: | https://commits.kde.org/baloo-widgets/e5cc92b87ef1c1fc344e89bc7941303692e11a00 | Version Fixed In: | 19.08.0 |
Sentry Crash Report: |
Description
Pedro Fayolle
2019-06-05 21:17:45 UTC
Probably just needs a setTextInteractionFlags(whatever flags it already sets | Qt::TextSelectableByMouse) in the label factory in baloo-widgets. Sounds like an easy patch :) Indeed. You can see how I did this for the Properties dialog here: https://cgit.kde.org/kio.git/commit/?id=025e5e9957ff92c8196f820e9490f337ebfbe317 You'd do the same here: https://cgit.kde.org/baloo-widgets.git/tree/src/filemetadatawidget.cpp#n121 Would you like to have a go at it, Pedro? I can help if you get stuck. Here's the documentation: https://community.kde.org/Get_Involved/development (In reply to Nate Graham from comment #2) > Indeed. You can see how I did this for the Properties dialog here: > https://cgit.kde.org/kio.git/commit/ > ?id=025e5e9957ff92c8196f820e9490f337ebfbe317 > > You'd do the same here: > https://cgit.kde.org/baloo-widgets.git/tree/src/filemetadatawidget.cpp#n121 > > Would you like to have a go at it, Pedro? I can help if you get stuck. > Here's the documentation: https://community.kde.org/Get_Involved/development Considering Pedro didn't respond, may I tackle it? Please feel free! I submitted a fix: https://phabricator.kde.org/D21740 Git commit e5cc92b87ef1c1fc344e89bc7941303692e11a00 by Nate Graham, on behalf of Gabriel Felipe Huwe. Committed on 11/06/2019 at 12:48. Pushed by ngraham into branch 'master'. Make text from Dolphin's information panel copyable Summary: Fixed text from Dolphin's information panel not being copyable by adding the correct text interaction flags to the label. FIXED-IN: 19.08.0 Reviewers: #baloo, #dolphin, ngraham Reviewed By: #baloo, #dolphin, ngraham Subscribers: ngraham, #dolphin, #baloo Tags: #dolphin, #baloo Differential Revision: https://phabricator.kde.org/D21740 M +1 -0 src/filemetadatawidget.cpp M +1 -0 src/widgetfactory.cpp https://commits.kde.org/baloo-widgets/e5cc92b87ef1c1fc344e89bc7941303692e11a00 |