Bug 408355

Summary:	Selection context menu missing find in this document
Product:	[Applications] okular	Reporter:	Edward Kigwana <ekigwana>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aacid, andysardina22, get.sonic, nate
Priority:	NOR	Keywords:	junior-jobs, usability
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/okular/commit/4a4a2a1b524b2b62b3bc41b1619c049ab1f05437	Version Fixed In:	1.9.0
Sentry Crash Report:

Description Edward Kigwana 2019-06-05 19:02:15 UTC

SUMMARY


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Edward Kigwana 2019-06-05 19:05:16 UTC

SUMMARY:

When using okular to view pdf schematics, it is handy to make a selection and then search within the document. I find it odd that it is possible to use the context selection to search google, youtube, yahoo but not in the document

Comment 2 Andi Sardina 2019-08-25 18:35:05 UTC

Hi, 
  I have sent a proposal to evaluation: https://phabricator.kde.org/D23421

Comment 3 Albert Astals Cid 2019-09-22 22:12:49 UTC

Git commit 4a4a2a1b524b2b62b3bc41b1619c049ab1f05437 by Albert Astals Cid, on behalf of Andy Sardina.
Committed on 22/09/2019 at 22:10.
Pushed by aacid into branch 'master'.

Add "find in this document" to selection context menu

FIXED-IN: 1.9.0

M  +6    -0    part.cpp
M  +19   -2    ui/pageview.cpp
M  +2    -0    ui/pageview.h

https://invent.kde.org/kde/okular/commit/4a4a2a1b524b2b62b3bc41b1619c049ab1f05437

Comment 4 Syam 2019-09-29 16:08:47 UTC

(In reply to Albert Astals Cid from comment #3)

Isn't "search for ... in this document" better than "search for ... in open document"?

The first time I saw the screenshot in 'this week in KDE' report, it took me a few seconds to understand that "open document" does not refer to ODF.

Comment 5 Nate Graham 2019-10-08 14:22:14 UTC

(In reply to Syam from comment #4)
> (In reply to Albert Astals Cid from comment #3)
> 
> Isn't "search for ... in this document" better than "search for ... in open
> document"?
> 
> The first time I saw the screenshot in 'this week in KDE' report, it took me
> a few seconds to understand that "open document" does not refer to ODF.
Thanks for the feedback. That's a good point. Fixed with https://invent.kde.org/kde/okular/commit/1da31df8b63d45984b31a41c212c545e7f785081