Bug 408286

Summary:	Build fails with GCC9
Product:	[Frameworks and Libraries] QtCurve	Reporter:	Christophe Marin <christophe>
Component:	general	Assignee:	Yichao Yu <yyc1992>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hein
Priority:	NOR
Version:	1.9
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/qtcurve/ee2228ea2f18ac5da9b434ee6089381df815aa94	Version Fixed In:
Sentry Crash Report:

Description Christophe Marin 2019-06-04 11:48:28 UTC

GCC9 is less permissive than previous versions, the current QtCurve version fails to build in openSUSE:

[  111s] /home/abuild/rpmbuild/BUILD/qtcurve-1.9.0/build/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h: In member function 'constexpr GObject* QtCurve::GtkWidgetProps::Props::_SigConn_shadowDestroy_ObjGetter::operator()(QtCurve::GtkWidgetProps::Props::SigConn<QtCurve::GtkWidgetProps::Props::_SigConn_shadowDestroy_ObjGetter>*) const':
[  111s] /home/abuild/rpmbuild/BUILD/qtcurve-1.9.0/build/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h:80:24: error: a reinterpret_cast is not a constant expression
[  111s]    80 |                 return (GObject*)qtcContainerOf(p, Props, name)->m_w;   \
[  111s]       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



This is the first error found, there may be others.
Full build log: https://build.opensuse.org/build/KDE:Extra/openSUSE_Tumbleweed/x86_64/qtcurve/_log

Comment 1 Yichao Yu 2019-06-05 13:05:54 UTC

Git commit ee2228ea2f18ac5da9b434ee6089381df815aa94 by Yichao Yu.
Committed on 05/06/2019 at 13:05.
Pushed by yuyichao into branch 'master'.

[utils/gtkprops] Remove unnecessary constexpr, this is not allowed in C++14

M  +1    -1    lib/utils/gtkprops.h

https://commits.kde.org/qtcurve/ee2228ea2f18ac5da9b434ee6089381df815aa94