Bug 408261

Summary:	In Metadata editor, "Ok" and "Apply" buttons should save changes for all tabs, not just the active one.
Product:	[Applications] digikam	Reporter:	MarcP <iwannaberich>
Component:	Plugin-Generic-MetadataEdit	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	iwannaberich
Priority:	NOR
Version First Reported In:	6.2.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/digikam/commit/83445b12286da6e1611efefe17469193fad11320	Version Fixed/Implemented In:	6.2.0
Sentry Crash Report:

Description MarcP 2019-06-03 18:44:57 UTC

SUMMARY

When using the metadata editor, there are three tabs: Edit EXIF, IPTC, and XMP. If any changes are made in several tabs and the Ok or Apply buttons are used, only those changes in the current/active tab will be saved. 

Right now, you have to click "Apply" before changing to another tab, otherwise the edits are lost.

I personally think the "Ok" and "Apply" buttons should save changes made in the three tabs.

STEPS TO REPRODUCE
1. Open metadata editor
2. Do some changes on one tab (e.g. change EXIF's Original date and time)
3. Move to another tab (e.g. XMP)
4. Click "Apply"
5. Go back to the previous tab.

OBSERVED RESULT
Changes in the previous tab have been lost (not applied).

EXPECTED RESULT
Changes should have been applied even if that tab did not have the focus.

SOFTWARE/OS VERSIONS
Ubuntu 18.04 with Gnome and digikam-6.2.0-git-20190522T104638-qtwebkit-x86-64.appimage

Comment 1 Maik Qualmann 2019-06-03 19:44:38 UTC

Git commit 83445b12286da6e1611efefe17469193fad11320 by Maik Qualmann.
Committed on 03/06/2019 at 19:43.
Pushed by mqualmann into branch 'master'.

fix applying the metadata on all tabs
FIXED-IN: 6.2.0

M  +2    -1    NEWS
M  +7    -3    core/dplugins/generic/metadata/metadataedit/exif/exifeditwidget.cpp
M  +7    -3    core/dplugins/generic/metadata/metadataedit/iptc/iptceditwidget.cpp
M  +8    -3    core/dplugins/generic/metadata/metadataedit/xmp/xmpeditwidget.cpp

https://invent.kde.org/kde/digikam/commit/83445b12286da6e1611efefe17469193fad11320

Comment 2 MarcP 2019-06-03 20:29:29 UTC

Thanks Maik!