Bug 408219

Summary: Streaks appear when cards are moved by the game
Product: [Applications] kpat Reporter: Ariel Rosenfeld <ariel.rosenfeld.750>
Component: generalAssignee: Stephan Kulow <coolo>
Status: RESOLVED FIXED    
Severity: minor CC: aacid, ariel.rosenfeld.750, kde-games-bugs-null
Priority: NOR    
Version First Reported In: 3.6   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Streaks left after the cards are placed

Description Ariel Rosenfeld 2019-06-02 18:05:05 UTC
Created attachment 120504 [details]
Streaks left after the cards are placed

SUMMARY
Streaks appear when cards are moved by the game

STEPS TO REPRODUCE
1. Open a game (its most obvious on spider or klondike)
2. Click new deal

OBSERVED RESULT
When the card animation places the cards on the stack streaks appear along the card movement leaving a trail

EXPECTED RESULT
No streaks

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3
Kernel Version: 5.1.5-arch1-2-ARCH
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-6700 CPU @ 3.40GHz
Memory: 31.4 GiB of RAM

ADDITIONAL INFORMATION
Comment 1 Christoph Feck 2019-06-25 14:29:18 UTC
Are you using a fractional screen scaling factor?
Comment 2 Ariel Rosenfeld 2019-06-25 16:23:37 UTC
Yes, I am using 1.1 as the screen resolution is 2560x1440.

I know there are more bugs relating to scaling but i haven't seen one for this app, so I thought I'd report it as it's easier to produce and see the streaks then in the other applications
Comment 3 Christoph Feck 2019-06-25 16:42:12 UTC
Hm, PatienceView is just a QGraphicsView. Maybe QGraphicsView does not use "round to outside" mode when rounding floating point coordinates that result from using fractional scaling. E.g. a rect with left=100.8 and right=200.2 needs to be rounded to left=100 and right=201. Same for top/bottom.
Comment 4 Albert Astals Cid 2019-06-25 21:46:53 UTC
there's at least one patch for kpat and "hidpi" support, noone has had time to "really review" them

https://phabricator.kde.org/D19920
Comment 5 Stephan Kulow 2023-02-27 08:25:36 UTC
The patch is closed, so I assume it's in - please let me know if that's wrong.