Bug 408213

Summary: '+' symbol is a legitimate win10 file character but unable to enter it into digiKam via Rename
Product: [Applications] digikam Reporter: xordevoreaux <xordevoreaux>
Component: DImg-FileIOAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 6.1.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/kde/digikam/commit/aed8b69fdf9529636e75abe66a9560f931e5d4ef Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:

Description xordevoreaux 2019-06-02 13:32:38 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Open Digicam, select a pic
2. Rename the pic
3. Start the pic's filename off with a + symbol


OBSERVED RESULT
The plus symbol is converted to an underscore.

EXPECTED RESULT
The plus symbol should become part of the file name

SOFTWARE/OS VERSIONS
MS Windows 10.

The plus symbol (+) is a legitimate file name character in Windows 10.
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2019-06-02 13:45:02 UTC 
Which file system do you use ?

'+' is not acceptable for Fat32 FS. See here :

https://en.wikipedia.org/wiki/Filename#Comparison_of_filename_limitations

It's can be complicated to detect the FS, especially under Windows. So this '+' restriction is generic and include NTFS in digiKam.

Gilles Caulier
Comment 2 Maik Qualmann 2019-06-02 14:24:37 UTC 
That's right, + characters should not be used on truncated file names like FAT file systems.

https://docs.microsoft.com/en-us/windows/desktop/msi/filename

It is possible that we will again differentiate between NTFS and FAT, but there have been discussions with users, that we do not use all these characters under Linux, because the later copying to other filesystem then the problems occur.

Maik
Comment 3 Maik Qualmann 2019-06-02 14:46:14 UTC 
Git commit aed8b69fdf9529636e75abe66a9560f931e5d4ef by Maik Qualmann.
Committed on 02/06/2019 at 14:45.
Pushed by mqualmann into branch 'master'.

allow the + character in the filename only for NTFS
FIXED-IN: 6.2.0

M  +2    -2    NEWS
M  +6    -1    core/utilities/advancedrename/advancedrenamemanager.cpp

https://invent.kde.org/kde/digikam/commit/aed8b69fdf9529636e75abe66a9560f931e5d4ef