Summary: | Assert saving lab to tiff. [GDB backtrace] | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | wolthera <griffinvalley> |
Component: | File formats | Assignee: | Tiar <tamtamy.tymona> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | dimula73, halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/3d1a4b0c63d7325835771b4a6f01af8296250c19 | Version Fixed In: | |
Sentry Crash Report: |
Description
wolthera
2019-06-01 12:04:13 UTC
The assert was added by Tymond during the file handling error reporting; can you take a look at what's up? I'm not sure the safe asserts here are actually a good idea, after all, we want to report the problems back to the user. But apart from that, something else must've broken. Here on master is just fails with error message :) I get the assert too: ASSERT (krita): "visitor->visit(root)" in file /home/boud/dev/krita/plugins/impex/tiff/kis_tiff_converter.cc, line 757 You probably used different build settings. Git commit 037a1d75ddfe00926707abc97ab5e12c58a72f86 by Agata Cacko. Committed on 11/06/2019 at 11:53. Pushed by tymond into branch 'master'. Remove wrongly placed assert in tiff export Previous version of tiff export assumed that if visitor returns false it means internal error, a bug in the code. Truth is, it can happen also if the image (or layer) has an unsupported color space. Hence deletion of the assert and replacement InternalError error code with just Failure. M +2 -2 plugins/impex/tiff/kis_tiff_converter.cc https://invent.kde.org/kde/krita/commit/037a1d75ddfe00926707abc97ab5e12c58a72f86 The above commit just fix the issue of assert being placed in a wrong location, so now instead of assert/crash, users will see the message that saving failed. It's because there is no support for LABA 8bit integer tiff images in Krita yet. I have the code for supporting this color space working etc., but it needs a bit of consideration and comparison with tiff specification. I will CC the add-support commit here, too. Git commit 3d1a4b0c63d7325835771b4a6f01af8296250c19 by Boudewijn Rempt, on behalf of Agata Cacko. Committed on 13/06/2019 at 06:00. Pushed by rempt into branch 'krita/4.2'. Remove wrongly placed assert in tiff export Previous version of tiff export assumed that if visitor returns false it means internal error, a bug in the code. Truth is, it can happen also if the image (or layer) has an unsupported color space. Hence deletion of the assert and replacement InternalError error code with just Failure. M +2 -2 plugins/impex/tiff/kis_tiff_converter.cc https://invent.kde.org/kde/krita/commit/3d1a4b0c63d7325835771b4a6f01af8296250c19 Git commit 0893c1a78427403164ec29c5c86a46869f57d057 by Agata Cacko. Committed on 15/06/2019 at 16:50. Pushed by tymond into branch 'master'. Add conversion of colorspace to tiff export Not every colorspace supported by Krita is supported by tiff. In case of exporting an image with an unsupported color space it should convert to the closest one. This commit ensures that. M +8 -0 plugins/impex/tiff/kis_tiff_converter.cc M +65 -21 plugins/impex/tiff/kis_tiff_writer_visitor.cpp https://invent.kde.org/kde/krita/commit/0893c1a78427403164ec29c5c86a46869f57d057 Git commit 0f123641b9e5c43a9a196342d606ec3ca93cde17 by Boudewijn Rempt, on behalf of Agata Cacko. Committed on 17/06/2019 at 08:17. Pushed by rempt into branch 'krita/4.2'. Add conversion of colorspace to tiff export Not every colorspace supported by Krita is supported by tiff. In case of exporting an image with an unsupported color space it should convert to the closest one. This commit ensures that. M +8 -0 plugins/impex/tiff/kis_tiff_converter.cc M +65 -21 plugins/impex/tiff/kis_tiff_writer_visitor.cpp https://invent.kde.org/kde/krita/commit/0f123641b9e5c43a9a196342d606ec3ca93cde17 Git commit d0c5d7697f2913e9913964d3407a564b90ebbcb5 by Agata Cacko. Committed on 18/06/2019 at 08:53. Pushed by tymond into branch 'master'. Add support for more color spaces in tiff impex This commit adds support for following color spaces/bit depths: Export: - laba i8, f32 - graya f16, f32 - cmykaf32 Import: - cmyka f32 - laba f32, f16, i8 Related: bug 391987 M +43 -9 plugins/impex/tiff/kis_tiff_converter.cc M +17 -9 plugins/impex/tiff/kis_tiff_writer_visitor.cpp https://invent.kde.org/kde/krita/commit/d0c5d7697f2913e9913964d3407a564b90ebbcb5 Git commit 52060c2c5ec2511f6fbbc8704e0bf8c43ae0a8a6 by Boudewijn Rempt, on behalf of Agata Cacko. Committed on 20/06/2019 at 10:31. Pushed by rempt into branch 'krita/4.2'. Add support for more color spaces in tiff impex This commit adds support for following color spaces/bit depths: Export: - laba i8, f32 - graya f16, f32 - cmykaf32 Import: - cmyka f32 - laba f32, f16, i8 Related: bug 391987 M +43 -9 plugins/impex/tiff/kis_tiff_converter.cc M +17 -9 plugins/impex/tiff/kis_tiff_writer_visitor.cpp https://invent.kde.org/kde/krita/commit/52060c2c5ec2511f6fbbc8704e0bf8c43ae0a8a6 |