Bug 408167

Summary: Clone layers not updated when hidden fill layer changed
Product: [Applications] krita Reporter: Carl Olsson <carl.olsson>
Component: Layer StackAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 4.2.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/kde/krita/commit/a1dfff77f420a4045e061b3d1b77bab978bf2ada Version Fixed In:
Sentry Crash Report:

Description Carl Olsson 2019-06-01 04:29:11 UTC 
SUMMARY
If a fill layer is hidden and the fill layer's pattern or colour are changed then any linked clone layers are not updated until visibility of the fill layer is toggled.

May be related: https://bugs.kde.org/show_bug.cgi?id=405536

STEPS TO REPRODUCE
1. Add a fill layer with pattern
2. Clone fill layer
3. Hide fill layer
4. Change pattern in fill layer

OBSERVED RESULT
Clone layer pattern remains unchanged

EXPECTED RESULT
Clone layer pattern should be updated to match fill layer

SOFTWARE/OS VERSIONS
Windows: Microsoft Windows 10 Pro 10.0.17763 Build 17763
Comment 1 Dmitry Kazakov 2019-06-13 11:31:13 UTC 
Git commit a3ef7b6f273ced29b5059bd40b8f875393bd5d05 by Dmitry Kazakov.
Committed on 13/06/2019 at 11:30.
Pushed by dkazakov into branch 'master'.

Fix rendering of clones, whose source is invisible

We cannot just skip rendering of layers, which has any clones attached,
becasue clones may fetch data from their projections.
Related: bug 405536

M  +3    -3    libs/image/kis_async_merger.cpp
M  +2    -2    libs/image/kis_layer.cc
M  +6    -0    libs/image/kis_projection_leaf.cpp
M  +1    -0    libs/image/kis_projection_leaf.h

https://invent.kde.org/kde/krita/commit/a3ef7b6f273ced29b5059bd40b8f875393bd5d05
Comment 2 Halla Rempt 2019-06-17 08:18:04 UTC 
Git commit a1dfff77f420a4045e061b3d1b77bab978bf2ada by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 17/06/2019 at 08:16.
Pushed by rempt into branch 'krita/4.2'.

Fix rendering of clones, whose source is invisible

We cannot just skip rendering of layers, which has any clones attached,
becasue clones may fetch data from their projections.
Related: bug 405536

M  +3    -3    libs/image/kis_async_merger.cpp
M  +2    -2    libs/image/kis_layer.cc
M  +6    -0    libs/image/kis_projection_leaf.cpp
M  +1    -0    libs/image/kis_projection_leaf.h

https://invent.kde.org/kde/krita/commit/a1dfff77f420a4045e061b3d1b77bab978bf2ada