Bug 408152

Summary:	Onion Skins make Bounding Box Transform Tool larger then expected.
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Tools/Transform	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arh983, dimula73, ghevan
Priority:	NOR
Version:	4.2.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/krita/commit/e725ea9774259b7acc0471f51aafe0baf3b9eb21	Version Fixed In:
Sentry Crash Report:

Description Bollebib 2019-05-31 14:20:22 UTC

When i'm working with frames i often activate onion skin lamp in the layer docker.



when this is active ,if you use transform tool, suddenly the transform tool also counts the onion skins for the total size of the tool. It should ONLY be looking at the current layer and pixeldata in that layer.


Disabling the lamp makes the transform too work normally

Comment 1 vanyossi 2019-07-04 02:52:44 UTC

*** Bug 408069 has been marked as a duplicate of this bug. ***

Comment 2 vanyossi 2019-09-24 03:19:33 UTC

Unassigning as currently not working on this.

Comment 3 Dmitry Kazakov 2019-11-18 14:19:49 UTC

Git commit adafa8b73887cf732ddb5cf41b2305a4f94b0fe6 by Dmitry Kazakov.
Committed on 18/11/2019 at 13:59.
Pushed by dkazakov into branch 'master'.

Fix transforming layers that have Onion Skins enabled

The patch implements a concept of KisDecoratedNodeInterface. All layers
that spit decorations data into the layers stack should inherit from it
and handle the requests properly.

M  +1    -0    libs/image/CMakeLists.txt
A  +28   -0    libs/image/KisDecoratedNodeInterface.cpp     [License: GPL (v2+)]
A  +53   -0    libs/image/KisDecoratedNodeInterface.h     [License: GPL (v2+)]
M  +23   -2    libs/image/kis_paint_layer.cc
M  +6    -1    libs/image/kis_paint_layer.h
M  +18   -0    libs/image/kis_selection_mask.cpp
M  +6    -1    libs/image/kis_selection_mask.h
M  +23   -3    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +2    -0    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h

https://invent.kde.org/kde/krita/commit/adafa8b73887cf732ddb5cf41b2305a4f94b0fe6

Comment 4 Dmitry Kazakov 2019-11-18 14:53:21 UTC

Git commit e725ea9774259b7acc0471f51aafe0baf3b9eb21 by Dmitry Kazakov.
Committed on 18/11/2019 at 14:20.
Pushed by dkazakov into branch 'krita/4.2'.

Fix transforming layers that have Onion Skins enabled

The patch implements a concept of KisDecoratedNodeInterface. All layers
that spit decorations data into the layers stack should inherit from it
and handle the requests properly.

M  +1    -0    libs/image/CMakeLists.txt
A  +28   -0    libs/image/KisDecoratedNodeInterface.cpp     [License: GPL (v2+)]
A  +53   -0    libs/image/KisDecoratedNodeInterface.h     [License: GPL (v2+)]
M  +23   -2    libs/image/kis_paint_layer.cc
M  +6    -1    libs/image/kis_paint_layer.h
M  +18   -0    libs/image/kis_selection_mask.cpp
M  +6    -1    libs/image/kis_selection_mask.h
M  +23   -3    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +2    -0    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h

https://invent.kde.org/kde/krita/commit/e725ea9774259b7acc0471f51aafe0baf3b9eb21