Bug 408139

Summary: Overall assessment wrong
Product: [Applications] partitionmanager Reporter: Sete <jolugaju>
Component: generalAssignee: Andrius Štikonas <andrius>
Status: RESOLVED FIXED    
Severity: normal CC: andrius, caiojcarvalho, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Example of a smart analysis of a HDD almost new
attachment-6780-0.html

Description Sete 2019-05-31 09:24:58 UTC
Created attachment 120426 [details]
Example of a smart analysis of a HDD almost new

SUMMARY
Smart analysis of a drive is wrong in the "Overall assessment".

STEPS TO REPRODUCE
1. Select Drive
2. Context Menu
3. Smart analysis

OBSERVED RESULT
Overall assessment: Has many bad sectors
Bad sectors: none

EXPECTED RESULT
Overall assessment: No comment about bad sectors if there are none

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro KDE 
KDE Plasma Version: 5.15.5

ADDITIONAL INFORMATION
I've tested 7 HDDs and 2 SSD.
Some of them were brand new.
All of them have "Overall assessment = Has many bad sectors" and then "Bad sectors = none"
Comment 1 Andrius Štikonas 2019-06-01 15:39:45 UTC
Confirming that it happens on my system too.

Probably a regression from libatasmart->smartmontools port but I guess should be easy to fix.
Comment 2 Andrius Štikonas 2019-06-04 22:08:33 UTC
It seems that m_Size = 0 in SmartDiskInformation class instead of being set to disk size. This causes bad assessment.
Comment 3 Andrius Štikonas 2019-06-04 23:59:32 UTC
I have a fix now. I'll push it tomorrow.
Comment 4 Sete 2019-06-05 19:55:37 UTC
Created attachment 120607 [details]
attachment-6780-0.html

That's great!
Thanks for letting me know.

JL

On Wed, Jun 5, 2019 at 7:26 PM Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=408139
>
> Andrius Štikonas <andrius@stikonas.eu> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>          Resolution|---                         |FIXED
>              Status|CONFIRMED                   |RESOLVED
>
> --
> You are receiving this mail because:
> You reported the bug.