| Summary: | Empty UI field when creating new Folder and adding feed to it | ||
|---|---|---|---|
| Product: | [Applications] akregator | Reporter: | Jan Thomas <jan.thomas.118+KDE> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 5.11.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/pim/akregator/-/commit/0c869e02caea41421d6a54feb2b03e3ec3aa9030 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Shows the unvisible UI element | ||
A possibly relevant merge request was started @ https://invent.kde.org/pim/akregator/-/merge_requests/57 Git commit 0c869e02caea41421d6a54feb2b03e3ec3aa9030 by Carl Schwan, on behalf of Wendi Gan. Committed on 23/12/2024 at 08:54. Pushed by carlschwan into branch 'master'. Fix extra empty line when adding a new feed When a new folder is created and a feed or folder is inserted into it, an extra empty line appears. This happens because, in Folder::insertChild and Folder::prependChild, the node is added to m_children first. If the folder is newly created, during SubscriptionListModel::subscriptionAdded, QSortFilterProxyModelPrivate::create_mapping calls SubscriptionListModel::rowCount, which counts one extra row, leading to an extra empty line. This commit modifies rowCount to decrement by 1 during insertion. Related: bug 412215, bug 420797 M +9 -2 src/subscription/subscriptionlistmodel.cpp M +1 -0 src/subscription/subscriptionlistmodel.h https://invent.kde.org/pim/akregator/-/commit/0c869e02caea41421d6a54feb2b03e3ec3aa9030 |
Created attachment 120301 [details] Shows the unvisible UI element SUMMARY Empty UI field when creating new Folder and adding one feed to it STEPS TO REPRODUCE 1. Create new Folder 2. Add a feed to it 3. Open the folder OBSERVED RESULT An empty feed element is shown under the added feed EXPECTED RESULT everything looks as normal Operating System: Manjaro Linux KDE Plasma Version: 5.15.5 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.3 Kernel Version: 5.0.15-1-MANJARO OS Type: 64-bit Processors: 4 × Intel® Core™ i3-4150 CPU @ 3.50GHz Memory: 7,2 GiB of RAM ADDITIONAL INFORMATION Restarting Akregator makes this issue dissapear I have tested this bug on another machine, it was reproducible there aswell.