| Summary: | Notification popup is only partially translatable | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Yuri Chornoivan <yurchor> |
| Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, aspotashev, lucia.mrenica, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/41e41b194c1f6856832ee658c59b357ee02a4eaa | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Popup in the Russian locale | ||
Probably because it is a QML singleton, will look into it. Thanks Git commit 41e41b194c1f6856832ee658c59b357ee02a4eaa by Kai Uwe Broulik. Committed on 27/05/2019 at 07:46. Pushed by broulik into branch 'Plasma/5.16'. [Notifications] Fix translations in popup The popup is a pure QML singleton and as such doesn't inherit the i18n context from the applet. Use i18nd explicitly. Differential Revision: https://phabricator.kde.org/D21422 M +3 -3 applets/notifications/package/contents/ui/EditContextMenu.qml M +7 -7 applets/notifications/package/contents/ui/JobDetails.qml M +9 -7 applets/notifications/package/contents/ui/JobItem.qml M +9 -7 applets/notifications/package/contents/ui/NotificationHeader.qml M +5 -5 applets/notifications/package/contents/ui/NotificationItem.qml M +1 -1 applets/notifications/package/contents/ui/ThumbnailStrip.qml https://commits.kde.org/plasma-workspace/41e41b194c1f6856832ee658c59b357ee02a4eaa |
Created attachment 120299 [details] Popup in the Russian locale SUMMARY Some strings from notification popup are not loaded in the runtime. STEPS TO REPRODUCE Run some task (e.g. copying) on some ~100% translated locale (sv, pt, uk). OBSERVED RESULT Messages "%1 (Paused)", "Cancel", etc. from ./package/contents/ui/*.qml are untranslated, though they were extracted into catalog, translated and can be seen in the corresponding .mo files. See the attached screenshot. EXPECTED RESULT Everything should be translated. SOFTWARE/OS VERSIONS Linux/KDE Plasma: 5.16 (available in About System) KDE Plasma Version: 5.16 KDE Frameworks Version: * Qt Version: * ADDITIONAL INFORMATION It was reported that replacing the corresponding i18n(...) calls with i18nd("plasma_applet_org.kde.plasma.notifications", ...) solves the problem. Thanks in advance for fixing this.