Bug 407822

Summary: subsequent ZModem upload failed to launch if cancel file dialog
Product: [Applications] konsole Reporter: rockmen1 <rockmen1>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 19.04.1   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/konsole/9685e23e2efe07a0763c7c7716eb805cc2228dfa Version Fixed In: 19.08.00

Description rockmen1 2019-05-22 09:09:18 UTC 
SUMMARY
If trigger ZModem for the first time and then cancel the file dialog, subsequent  attempts will report "The current session already has a ZModem file transfer in progress."

STEPS TO REPRODUCE
1. Launch ZModem upload from menu, and cancel the file diaglog
2. Start over

EXPECTED RESULT
If previous upload was canceled, it shall allow to start again


SOFTWARE/OS VERSIONS
Linux: Arch Linux
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
Had seen this issue for previous versions already
Comment 1 Kurt Hindenburg 2019-06-01 18:54:18 UTC 
Git commit 0509982a7cd178ac774a75a000af82ebf2688855 by Kurt Hindenburg.
Committed on 01/06/2019 at 18:50.
Pushed by hindenburg into branch 'BR407822'.

Remove unneeded setZModemBusy(true)

_zmodemBusy is set to true in startZModem() so there's no need to
set it before.
FIXED-IN: 19.08.00

M  +0    -1    src/SessionController.cpp

https://invent.kde.org/kde/konsole/commit/0509982a7cd178ac774a75a000af82ebf2688855
Comment 2 Kurt Hindenburg 2019-06-01 18:54:20 UTC 
Git commit 0509982a7cd178ac774a75a000af82ebf2688855 by Kurt Hindenburg.
Committed on 01/06/2019 at 18:50.
Pushed by scmsync into branch 'BR407822'.

Remove unneeded setZModemBusy(true)

_zmodemBusy is set to true in startZModem() so there's no need to
set it before.
FIXED-IN: 19.08.00

M  +0    -1    src/SessionController.cpp

https://commits.kde.org/konsole/0509982a7cd178ac774a75a000af82ebf2688855
Comment 3 Kurt Hindenburg 2019-06-01 18:56:22 UTC 
Well this was committed to a branch and I didn't realize it would close this.  It will be committed to master shortly
Comment 4 Kurt Hindenburg 2019-06-02 00:23:37 UTC 
Git commit 9685e23e2efe07a0763c7c7716eb805cc2228dfa by Kurt Hindenburg.
Committed on 02/06/2019 at 00:23.
Pushed by hindenburg into branch 'master'.

Remove unneeded setZModemBusy(true)

_zmodemBusy is set to true in startZModem() so there's no need to
set it before.
FIXED-IN: 19.08.00

M  +0    -1    src/SessionController.cpp

https://invent.kde.org/kde/konsole/commit/9685e23e2efe07a0763c7c7716eb805cc2228dfa
Comment 5 Kurt Hindenburg 2019-06-02 00:23:41 UTC 
Git commit 9685e23e2efe07a0763c7c7716eb805cc2228dfa by Kurt Hindenburg.
Committed on 02/06/2019 at 00:23.
Pushed by scmsync into branch 'master'.

Remove unneeded setZModemBusy(true)

_zmodemBusy is set to true in startZModem() so there's no need to
set it before.
FIXED-IN: 19.08.00

M  +0    -1    src/SessionController.cpp

https://commits.kde.org/konsole/9685e23e2efe07a0763c7c7716eb805cc2228dfa