Bug 407799

Summary: elisa 0.4.0 fails to build with cmake < 3.12
Product: [Applications] Elisa Reporter: Wolfgang Bauer <wbauer1>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 0.4.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/elisa/22661106f8f875506bbaf1b764a5b52c9adfe9ff Version Fixed/Implemented In:
Sentry Crash Report:

Description Wolfgang Bauer 2019-05-21 13:33:20 UTC 
...but still specifies 3.5 as minimum version...

The reason is https://cgit.kde.org/elisa.git/commit/CMakeLists.txt?id=15577c7992338d4f91040ff65f7c90bb5827501f.

According to the cmake documentation, DESCRIPTION only exists since 3.9, while HOMEPAGE_URL even needs 3.12.
Comment 1 Wolfgang Bauer 2019-05-21 13:50:41 UTC 
Additionally, set(CMAKE_CXX_STANDARD 17) needs cmake 3.8 at least, earlier versions only supported values up to 14.
Comment 2 Matthieu Gallien 2019-05-21 14:17:25 UTC 
Thanks for the report. I will revert in the 0.4 branch and fix master.
Comment 3 Matthieu Gallien 2019-05-21 15:18:31 UTC 
Git commit af758c666eb1f59ec68c438d1a76df894e521069 by Matthieu Gallien.
Committed on 21/05/2019 at 15:17.
Pushed by mgallien into branch '0.4'.

Revert "give cmake more information in project command (version, ...)"

This reverts commit 15577c7992338d4f91040ff65f7c90bb5827501f.

M  +1    -6    CMakeLists.txt

https://commits.kde.org/elisa/af758c666eb1f59ec68c438d1a76df894e521069
Comment 4 Matthieu Gallien 2019-05-22 05:20:59 UTC 
Git commit 22661106f8f875506bbaf1b764a5b52c9adfe9ff by Matthieu Gallien.
Committed on 22/05/2019 at 05:17.
Pushed by mgallien into branch 'master'.

require cmake 3.12

M  +1    -1    CMakeLists.txt

https://commits.kde.org/elisa/22661106f8f875506bbaf1b764a5b52c9adfe9ff