| Summary: | Button icons blurry on HiDPI | ||
|---|---|---|---|
| Product: | [Applications] yakuake | Reporter: | markuss <kamikazow> |
| Component: | general | Assignee: | markuss <kamikazow> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, nate, nicolas |
| Priority: | NOR | ||
| Version: | 3.0.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/yakuake/0134f68c906957be49fa8c14fa34ef335db1165b | Version Fixed In: | 19.12.0 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
I hope assigning this bug to Nate is OK. He's done much HiDPI work as far as I can see. Nope, I don't work on Yakuake, sorry. However seeing as you've taken an interest, why don't we assign it to you? :) You can easily try out the typical fix yourself; it's a simple one-line change and it's very easy. Add "app.setAttribute(Qt::AA_UseHighDpiPixmaps, true);" right below here https://cgit.kde.org/yakuake.git/tree/app/main.cpp#n33 Then re-compile Sakuake, run it, and see if that helps. This is all described here: https://community.kde.org/Get_Involved/development#Applications Let me know if you need a hand with anything. (In reply to Nate Graham from comment #2) > Let me know if you need a hand with anything. Move Yakuake to GitLab, so I can have a nice web-based editor than to fight with Git for a single line. :p *** This bug has been marked as a duplicate of bug 397590 *** (In reply to Nate Graham from comment #2) > Let me know if you need a hand with anything. You could merge https://phabricator.kde.org/D19237 if nobody else does. Not a dupe. The other bug is about the title bar buttons (those have been fixed). This is about OK/Cancel buttons in preferences. The issue is still present. I've built locally and adding QGuiApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true); just after main() helps indeed. I've opened a change request on phabricator: maybe someone is interested (and has the rights) to merge it: https://phabricator.kde.org/D25038 (In reply to Nicolas from comment #8) > I've opened a change request on phabricator: maybe someone is interested > (and has the rights) to merge it: https://phabricator.kde.org/D25038 I has just applied your patch on my system. It fixes this issue. Git commit 0134f68c906957be49fa8c14fa34ef335db1165b by Nate Graham, on behalf of Nicolas Höft. Committed on 21/11/2019 at 19:42. Pushed by ngraham into branch 'release/19.12'. Enable high DPI pixmaps Summary: Enable High DPI pixmaps to make icons in dialogs looks nice if High DPI is enabled. Test Plan: Checked manually in high DPI environment. Reviewers: hein, cfeck, ngraham Reviewed By: cfeck, ngraham Subscribers: ngraham Differential Revision: https://phabricator.kde.org/D25038 M +1 -0 app/main.cpp https://commits.kde.org/yakuake/0134f68c906957be49fa8c14fa34ef335db1165b |
Created attachment 120181 [details] Screenshot Both the title bar buttons as well as OK/Cancel buttons in preferences are blurry on HiDPI. See attached screenshot.