| Summary: | Task switcher doesn’t show if win key is mapped to alt | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | ariasuni <aria> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, nate, zuxio0iezici7oov |
| Priority: | NOR | Flags: | vlad.zahorodnii:
Wayland-
vlad.zahorodnii: X11+ vlad.zahorodnii: ReviewRequest+ |
| Version: | 5.15.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D21302 | ||
| Latest Commit: | https://commits.kde.org/kwin/499eccb1c8d75f596bc736cef5ce53aa0eb16e16 | Version Fixed In: | 5.16.3 |
| Sentry Crash Report: | |||
|
Description
ariasuni
2019-05-19 11:26:18 UTC
it seems related to bug 404115 Given that kwin switches one window forward, it seems like the shortcut works correctly. Most likely kwin thinks that modifiers are not depressed. I wonder why we need areKeySymXsDepressed. Aha! areKeySymXsDepressed makes some false assumptions about xcb_key_symbols_get_keycode. A keysym can be mapped to several keycodes, so we need to iterate over returned values and check if any modifier is depressed, though I would prefer to share areModKeysDepressedWayland on both Wayland session and X11 session. You’re right, it seems related to bug 404115. No, not really. Git commit 2cff5cb70a9e680f7c14fbd60b00e31143373399 by Vlad Zagorodniy. Committed on 21/05/2019 at 12:43. Pushed by vladz into branch 'master'. [tabbox] Properly determine depressed modifiers on X11 Summary: A keysym can be assigned to several keycodes, so more proper way to determine whether given modifier is depressed is to iterate over all returned keycodes and see if any is pressed. If we check only the first keycode, then alternative mappings may not work, e.g. alt key mapped to win, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21302 M +23 -29 tabbox/tabbox.cpp https://commits.kde.org/kwin/2cff5cb70a9e680f7c14fbd60b00e31143373399 Thanks a lot!! This is not fixed in my experience. I'm running with Plasma/KWin 5.16.2, Frameworks 5.59.0 and Qt 5.12.4 and I'm still observing this behaviour. Can you post your .config/kxkbrc? Heh, yeah, that's right. I forgot to backport the patch to 5.16 branch. Git commit 499eccb1c8d75f596bc736cef5ce53aa0eb16e16 by Vlad Zagorodniy. Committed on 30/06/2019 at 12:46. Pushed by vladz into branch 'Plasma/5.16'. [tabbox] Properly determine depressed modifiers on X11 Summary: A keysym can be assigned to several keycodes, so more proper way to determine whether given modifier is depressed is to iterate over all returned keycodes and see if any is pressed. If we check only the first keycode, then alternative mappings may not work, e.g. alt key mapped to win, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21302 M +23 -29 tabbox/tabbox.cpp https://commits.kde.org/kwin/499eccb1c8d75f596bc736cef5ce53aa0eb16e16 |