| Summary: | Create a filter or fill layer with selection > Paint on it > Crash | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Tools/Selection | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version First Reported In: | 4.2.0-alpha | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/b5b8e1e8a6181e94cc745ed45fe198f647c2819f | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
acc4commissions
2019-05-19 02:54:26 UTC
The bug seem to be Windows-specific. It is not reproducible on Linux, even with ASAN. Git commit f7d4ad8dbd42a344aab8b868a0170d0794629031 by Dmitry Kazakov. Committed on 23/05/2019 at 11:21. Pushed by dkazakov into branch 'master'. Add an assert for checking that vector selection is not cloned in non-gui thread This assert will let us know if we have any code that uses it. M +8 -0 libs/ui/flake/kis_shape_selection.cpp https://invent.kde.org/kde/krita/commit/f7d4ad8dbd42a344aab8b868a0170d0794629031 Git commit 7b04a0238c289ca08c080bd09fb3b4f42cf8a884 by Dmitry Kazakov.
Committed on 23/05/2019 at 11:21.
Pushed by dkazakov into branch 'master'.
Fix crash when painting on a filter layer with vector selection
It looks like cloning of a vector selection is not very safe in non-gui
thread, so we should just read from its projection when rendering.
TODO: either make cloning safe or check we don't do such copies
anywhere else
BACKPORT:krita/4.2
M +8 -3 libs/image/kis_selection_based_layer.cpp
https://invent.kde.org/kde/krita/commit/7b04a0238c289ca08c080bd09fb3b4f42cf8a884
Git commit b5b8e1e8a6181e94cc745ed45fe198f647c2819f by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 23/05/2019 at 11:56.
Pushed by rempt into branch 'krita/4.2'.
Fix crash when painting on a filter layer with vector selection
It looks like cloning of a vector selection is not very safe in non-gui
thread, so we should just read from its projection when rendering.
TODO: either make cloning safe or check we don't do such copies
anywhere else
BACKPORT:krita/4.2
(cherry picked from commit 7b04a0238c289ca08c080bd09fb3b4f42cf8a884)
M +8 -3 libs/image/kis_selection_based_layer.cpp
https://invent.kde.org/kde/krita/commit/b5b8e1e8a6181e94cc745ed45fe198f647c2819f
|