Summary: | sddm_kcm shows an empty error message when I cancel the password dialog to allow the installation of a theme via GHNS window | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander.lohnau, filipfila.kde, lv215bd5, nate |
Priority: | NOR | ||
Version: | 5.17.90 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/sddm-kcm/commit/8acacca14eba2c445b0e9dd8a9b4193cb48cfb7d | Version Fixed In: | 5.20 |
Attachments: |
screenshot
"Installed" section of GHNS window canceling plasma settings sync with sddm |
Description
Patrick Silva
2019-05-18 12:28:02 UTC
Created attachment 120163 [details]
screenshot
Created attachment 120164 [details]
"Installed" section of GHNS window
As we can see in the second screenshot, "Installed" section of GHNS window shows the theme as installed but it is not available for selection in the sddm_kcm.
Well it used to crash so I guess we're making progress. :) *** Bug 422992 has been marked as a duplicate of this bug. *** This has been fixed some time ago when I was fixing the exact same issue for the dolphin installer :-). The sddm theme is no longer installed after the password dialog to be canceled, but the empty error message persists. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.73.0 Qt Version: 5.14.2 Created attachment 130563 [details]
canceling plasma settings sync with sddm
Possibly related issue: also empty error message when I cancel the authentication to sync plasma settings with sddm. Watch the screen recording please.
Operating System: Arch Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0
A possibly relevant merge request was started @ https://invent.kde.org/plasma/sddm-kcm/-/merge_requests/2 Git commit 8acacca14eba2c445b0e9dd8a9b4193cb48cfb7d by Alexander Lohnau. Committed on 28/08/2020 at 16:17. Pushed by alex into branch 'master'. Avoid empty message dialogs, cleanup - Choose better QString overloads - Remove unused variables - Add missing emit keywords - Avoid multi-arg method call - Avoid detaching in loop - Do not show empty error messages, for exmple when the user clicks the cancel button FIXED-IN: 5.20 M +3 -2 sddmauthhelper.cpp M +3 -2 sddmthemeinstaller.cpp M +8 -4 src/advancedconfig.cpp M +4 -4 src/sddmkcm.cpp M +1 -5 src/themesdelegate.cpp https://invent.kde.org/plasma/sddm-kcm/commit/8acacca14eba2c445b0e9dd8a9b4193cb48cfb7d |