Bug 407656

Summary: I deleted x files and got a notification about x-1 files being deleted
Product: [Frameworks and Libraries] frameworks-kio Reporter: Lucia Mrenica <lucia.mrenica>
Component: generalAssignee: David Faure <faure>
Status: RESOLVED FIXED    
Severity: normal CC: cuervodesantos, kdelibs-bugs-null, lucia.mrenica, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.58.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/kio/0532047f8b9738fe5fee7559596a84f77024c042 Version Fixed/Implemented In: 5.60
Sentry Crash Report:

Description Lucia Mrenica 2019-05-17 17:38:01 UTC 
SUMMARY
I selected 4 files in Dolphin.
I got a notification about a pending deletion of 4 files.
After all files were deleted I got a message that 3 files were moved to the trash.
In reality, all 4 files were moved to the Trash succesfully.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58
Qt Version: 5.13.0 beta3

ADDITIONAL INFORMATION
Tested on wayland.
I am not sure about Product nor Component.
Comment 1 Kai Uwe Broulik 2019-05-23 13:17:45 UTC 
You mean delete or move to trash? I can confirm that the finished notification for trashing files shows a lower number of files. It probably doesn't report the final state before finishing the job. Re-assigning to KIO.
Comment 2 Lucia Mrenica 2019-05-23 13:42:15 UTC 
(In reply to Kai Uwe Broulik from comment #1)
> You mean delete or move to trash? I can confirm that the finished
> notification for trashing files shows a lower number of files. It probably
> doesn't report the final state before finishing the job. Re-assigning to KIO.

Yes, I mean Moving to Trash.
Comment 3 Kai Uwe Broulik 2019-07-02 13:20:34 UTC 
Git commit 0532047f8b9738fe5fee7559596a84f77024c042 by Kai Uwe Broulik.
Committed on 02/07/2019 at 13:09.
Pushed by broulik into branch 'master'.

[CopyJob] Report results after finishing copy

Currently, slotReport is called all the way at the end when in STATE_SETTING_DIR_ATTRIBUTES. However, slotReport does nothing in this state.
Instead, move it to before changing away from STATE_COPYING_FILES so that progress is correctly reported for a final time.

Differential Revision: https://phabricator.kde.org/D19585

M  +3    -2    src/core/copyjob.cpp

https://commits.kde.org/kio/0532047f8b9738fe5fee7559596a84f77024c042