Bug 407636

Summary: New Home Button does not behave like a button
Product: [Applications] Discover Reporter: Sefa Eyeoglu <contact>
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Status: RESOLVED FIXED    
Severity: minor CC: aleixpol, bfeber, nate
Priority: NOR    
Version First Reported In: 5.15.90   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/discover/66f3bec028254c3551a98d9d7933e9269b361611 Version Fixed/Implemented In: 5.16.0
Sentry Crash Report:

Description Sefa Eyeoglu 2019-05-17 11:15:02 UTC 
SUMMARY
The new Home Button on the top left doesn't behave like a button. It does trigger on mouse-down rather than on mouse-up and does not highlight on mouse-down either.

STEPS TO REPRODUCE
1. Start Discover
2. Hold your mouse on the home button

OBSERVED RESULT
The button does not highlight, that it is pressed and it triggers instantly.

EXPECTED RESULT
The button should first highlight and trigger, when the mouse button doesn't get pressed anymore, like a normal button.

SOFTWARE/OS VERSIONS
Linux: Arch Linux with kde-unstable repository
(available in About System)
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION
I know this is a very minor bug. It should be even below minor, but this is something for Nate's weekly report :D
Comment 1 Nate Graham 2019-05-28 03:18:46 UTC 
Whoops, my bad!
Comment 2 Björn Feber 2019-05-28 15:03:43 UTC 
Git commit 66f3bec028254c3551a98d9d7933e9269b361611 by Björn Feber.
Committed on 28/05/2019 at 15:03.
Pushed by bfeber into branch 'Plasma/5.16'.

Use onClicked for Home button

Summary:
FIXED-IN: 5.16.0

Buttons should use onClicked instead of onPressed.

Test Plan: Click on the Home button. It now behaves correctly.

Reviewers: #plasma, #vdg, ngraham, apol

Reviewed By: #vdg, ngraham, apol

Subscribers: ngraham, #vdg, plasma-devel, #plasma

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21436

M  +1    -1    discover/qml/DiscoverDrawer.qml

https://commits.kde.org/discover/66f3bec028254c3551a98d9d7933e9269b361611