Summary: | Impossible to change the wallpaper immediately after changing the layout setting | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
Component: | Image Wallpaper | Assignee: | Sebastian Kügler <sebas> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | karl, nate, notmart, plasma-bugs, qydwhotmail |
Priority: | NOR | Keywords: | qt6, regression |
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/d500c0d4a85d81baef50e67f3c364bf9dc66ae7c | Version Fixed In: | 6.0 |
Bug Depends on: | 454597 | ||
Bug Blocks: | 454595 |
Description
Patrick Silva
2019-05-16 21:36:44 UTC
Confirmed. *** Bug 427156 has been marked as a duplicate of this bug. *** Still valid in Plasma 5.24.4. After changing to a new layout and selecting a new wallpaper, the ‘Apply’ button is greyed out and can’t be clicked, while the ‘OK’ button closes the dialogue but doesn’t change the wallpaper. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/964 Git commit 29c79a56fd0f79e0b9b35130b2ea899b5d26ce7c by Fushan Wen. Committed on 14/06/2022 at 11:29. Pushed by fusionfuture into branch 'Plasma/5.24'. desktoppackage: fix unable to apply wallpaper settings after switching layout `wallpaperGraphicsObject`, `wallpaper` or `wallpaperInterface` is not set before calling `ContainmentInterface::loadWallpaper()`, so wait until `wallpaperInterfaceChanged` signal is emitted. At that time `applyWallpaper()` will call `syncWallpaperObjects()` to update `wallpaperConfiguration`. FIXED-IN: 5.24.6 (cherry picked from commit 379d162a126f504ebdbb66b68852e7d850dd51b0) M +23 -3 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml https://invent.kde.org/plasma/plasma-desktop/commit/29c79a56fd0f79e0b9b35130b2ea899b5d26ce7c Git commit 50f82b2d47d016d750c13f7c2abfe20dbfbd9837 by Fushan Wen. Committed on 22/06/2022 at 08:02. Pushed by fusionfuture into branch 'master'. desktoppackage: avoid loading wallpaper settings again when the plugin is changed Only reload wallpaper settings when `wallpaperConfiguration` is invalid. M +3 -7 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml https://invent.kde.org/plasma/plasma-desktop/commit/50f82b2d47d016d750c13f7c2abfe20dbfbd9837 Git commit f3867eb3d24e3cc4d03faf1d2ce2e8e8e0ab578c by Fushan Wen. Committed on 22/06/2022 at 08:03. Pushed by fusionfuture into branch 'Plasma/5.25'. desktoppackage: avoid loading wallpaper settings again when the plugin is changed Only reload wallpaper settings when `wallpaperConfiguration` is invalid. (cherry picked from commit 50f82b2d47d016d750c13f7c2abfe20dbfbd9837) M +3 -7 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml https://invent.kde.org/plasma/plasma-desktop/commit/f3867eb3d24e3cc4d03faf1d2ce2e8e8e0ab578c Git commit 988fe02de567b972a941bcb3d785cae5423c5e1d by Fushan Wen. Committed on 24/06/2022 at 09:45. Pushed by fusionfuture into branch 'Plasma/5.24'. desktoppackage: avoid loading wallpaper settings again when the plugin is changed Only reload wallpaper settings when `wallpaperConfiguration` is invalid. (cherry picked from commit 50f82b2d47d016d750c13f7c2abfe20dbfbd9837) M +3 -7 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml https://invent.kde.org/plasma/plasma-desktop/commit/988fe02de567b972a941bcb3d785cae5423c5e1d A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/853 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3191 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1669 Git commit dd3204eda894bebeae3c0a39c34b5745e44ac2df by Fushan Wen. Committed on 17/08/2023 at 11:56. Pushed by fusionfuture into branch 'master'. containment: emit signal when wallpaperGraphicsObject changes M +14 -0 src/plasma/containment.cpp M +12 -0 src/plasma/containment.h M +1 -0 src/plasma/private/containment_p.h https://invent.kde.org/frameworks/plasma-framework/-/commit/dd3204eda894bebeae3c0a39c34b5745e44ac2df Git commit d500c0d4a85d81baef50e67f3c364bf9dc66ae7c by Fushan Wen. Committed on 17/08/2023 at 18:15. Pushed by fusionfuture into branch 'master'. DesktopView: reopen containment config dialog after wallpaper item is loaded Until wallpaperGraphicsObject is a valid object, the config dialog can't properly load any wallpaper config view. M +9 -1 shell/desktopview.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/d500c0d4a85d81baef50e67f3c364bf9dc66ae7c Git commit ed239bcef7650596ae23b1eb128b145d15d6ebb2 by Fushan Wen. Committed on 17/08/2023 at 12:02. Pushed by fusionfuture into branch 'master'. desktoppackage: remove invalid connection The connection doesn't work since the wallpaperitem change M +1 -12 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/ed239bcef7650596ae23b1eb128b145d15d6ebb2 |