Bug 407591

Summary:	plugins/extensions/pykrita/plugin: missing parallel-make dependency
Product:	[Applications] krita	Reporter:	Vladimír Čunát <vcunat>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla
Priority:	NOR
Version:	4.1.7
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/f1aebe4ab8584b2d2f65b38ff4b837e3db17705a	Version Fixed In:
Sentry Crash Report:

Description Vladimír Čunát 2019-05-16 09:51:36 UTC

SUMMARY

/build/krita-4.1.8/plugins/extensions/pykrita/plugin/pyqtpluginsettings.cpp:19:10: fatal error: ui_manager.h: No such file or directory
 #include "ui_manager.h"

As usual, you may need many CPU cores and some luck.


EXPECTED RESULT

The generated makefiles include a (transitive) dependency between these two files.


SOFTWARE/OS VERSIONS

Probably not relevant; ask if you're missing some information.

Comment 1 Halla Rempt 2019-05-16 09:55:07 UTC

 I have never seen this happen either, not even on the 20 core black monster we use sometimes for Windows builds... I don't think there's anything we can do about this, at least, I have no idea: if you know how to fix this in the CMakeLists.txt, can you please provide a patch?.

Comment 2 Vladimír Čunát 2019-05-16 10:02:20 UTC

I tried to find a fix, but I didn't find a way fast enough.  I don't use cmake or Qt in development.

This time it was a 48-core, possibly heavily loaded at that moment.  Even so, I inspected many builds on the farm and it's happened only once, so I certainly don't consider it an important bug, as re-trying will probably help.

Comment 3 Halla Rempt 2019-05-16 10:07:53 UTC

Ah, that's even bigger than our black monster, on load from Intel :-) Maybe https://cmake.org/cmake/help/v3.9/prop_tgt/AUTOUIC.html would be helpful.

Comment 4 Vladimír Čunát 2019-05-16 10:12:29 UTC

Perhaps.  I looked at https://doc.qt.io/qt-5/cmake-manual.html before filing this ticket.  Maybe rewriting according to that style would solve the problem, but I can't say I understand these things.

Comment 5 Halla Rempt 2020-05-04 11:34:31 UTC

I'm sorry, but I think there isn't much we can do. I think this just is something cmake does, so I'm going to close the report.

Comment 6 Halla Rempt 2021-01-09 09:45:35 UTC

Git commit 03f5fe9cd0f485bbedd6b211eb3b1403d1a8850e by Halla Rempt.
Committed on 09/01/2021 at 09:45.
Pushed by rempt into branch 'master'.

Enable parallel builds of pykrita/plugin and pykrita/kritarunnuer
Related: bug 431226

M  +5    -0    plugins/extensions/pykrita/kritarunner/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/03f5fe9cd0f485bbedd6b211eb3b1403d1a8850e

Comment 7 Halla Rempt 2021-01-09 09:46:07 UTC

Git commit e410004e7ac63d75fb1613e34b3b4ba0b3b3e1ce by Halla Rempt.
Committed on 09/01/2021 at 09:45.
Pushed by rempt into branch 'krita/4.3'.

Enable parallel builds of pykrita/plugin and pykrita/kritarunnuer
Related: bug 431226
(cherry picked from commit 03f5fe9cd0f485bbedd6b211eb3b1403d1a8850e)

M  +5    -0    plugins/extensions/pykrita/kritarunner/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/e410004e7ac63d75fb1613e34b3b4ba0b3b3e1ce

Comment 8 Halla Rempt 2021-01-09 09:46:41 UTC

Git commit f1aebe4ab8584b2d2f65b38ff4b837e3db17705a by Halla Rempt.
Committed on 09/01/2021 at 09:46.
Pushed by rempt into branch 'krita/4.4.2'.

Enable parallel builds of pykrita/plugin and pykrita/kritarunnuer
Related: bug 431226
(cherry picked from commit 03f5fe9cd0f485bbedd6b211eb3b1403d1a8850e)

M  +5    -0    plugins/extensions/pykrita/kritarunner/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/f1aebe4ab8584b2d2f65b38ff4b837e3db17705a