Bug 407534

Summary: Unchecking "Show even in dnd mode" for Spectacle not working
Product: [Plasma] plasmashell Reporter: Patrick Silva <bugseforuns>
Component: NotificationsAssignee: Kai Uwe Broulik <kde>
Status: RESOLVED FIXED    
Severity: normal CC: kde, nate, plasma-bugs
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-workspace/a24166f72fbd2a3f66d49e26e7b7eb755c9fd99a Version Fixed In: 5.16.0
Sentry Crash Report:

Description Patrick Silva 2019-05-14 18:39:14 UTC 
STEPS TO REPRODUCE
1. activate "Do not disturb" mode in notifications applet
2. press shift+printscreen to take a screenshot with spectacle (plasma shows a notification)
3. open system settings > Notifications
4. click "Configure..." button on botton
5. select "Spectacle" in the applications list
6. uncheck "Show in do not disturb mode" and click "Apply" button
7. take a screenshot with spectacle again by pressing shift+printscreen

OBSERVED RESULT
plasma shows notification in "Do not disturb" mode
even when "Show in do not disturb mode" related to the
source app is unchecked in notifications kcm.

EXPECTED RESULT
do not show notifications while "Do not disturb" mode is activated

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 1 David Redondo 2019-05-17 09:00:53 UTC 
I think this intended behavior. I see two reasons for that. First the user should know  that a screenshot has been taken for security and privacy concerns  depending on the screenshots because it is saved as a file. For example it could have been triggered by accidentally activating the shortcut. Second if you take a screenshot there is a high chance that you want to interact with it - for example drag and drop it from the notification.
Comment 2 David Redondo 2019-05-17 09:12:11 UTC 
The reasons I gave are my ideas. But I think this is working as intended because I remembering Kai saying that Spectacle should be exempt from Do not disturb while he was implementing the new notifications
Comment 3 David Redondo 2019-05-17 11:14:34 UTC 
https://cgit.kde.org/plasma-workspace.git/tree/libnotificationmanager/plasmanotifyrc

Here is spectacle excluded from do not disturb
Comment 4 Nate Graham 2019-05-21 19:12:51 UTC 
Correct, this is behaving as intended. Even in "Do Not Disturb" mode, we show so-called "critical" notifications (e.g. "your laptop is about to run out of power"). Spectacle's notifications are marked as critical for the reasons that David provided.
Comment 5 Kai Uwe Broulik 2019-05-23 13:53:43 UTC 
Well, the bug explicitly states that the setting is broken, not the fact that we have spectacle by default.
I can confirm that unchecking the setting in Spectacle doesn't work. Probably a bug in the code that writes the config, using revertToDefault.
Comment 6 Kai Uwe Broulik 2019-05-29 11:49:20 UTC 
Git commit a24166f72fbd2a3f66d49e26e7b7eb755c9fd99a by Kai Uwe Broulik.
Committed on 29/05/2019 at 11:47.
Pushed by broulik into branch 'Plasma/5.16'.

[Notifications] Check proper group for show popups in dnd mode setting

It checked the wrong one resulting in the setting not being written.
FIXED-IN: 5.16.0

Differential Revision: https://phabricator.kde.org/D21475

M  +1    -1    libnotificationmanager/settings.cpp

https://commits.kde.org/plasma-workspace/a24166f72fbd2a3f66d49e26e7b7eb755c9fd99a