Bug 407478

Summary: Some brush tips appear black in the brush editor
Product: [Applications] krita Reporter: acc4commissions
Component: Brush enginesAssignee: Halla Rempt <halla>
Status: RESOLVED FIXED    
Severity: normal CC: ghevan, halla
Priority: NOR    
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/kde/krita/commit/ca5aeb769e0db415985b82c7527e45c96f51ec6f Version Fixed In:
Sentry Crash Report:
Attachments: Capture
Capture 2

Description acc4commissions 2019-05-13 03:36:16 UTC 
Created attachment 120027 [details]
Capture

SUMMARY
git 220be8f
Some brush tips appear black in the brush editor > Brush Tip > Predefined

I'm not entirely sure but probably the same issue as the one addressed in here : https://twitter.com/LiuSulitar/status/1126462059892355073


SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 vanyossi 2019-05-13 05:02:23 UTC 
PNG with transparency shows as completely dark/black tips. it is related, there is something weird going on.

Default tips does not have transparency making the issue elusive.
Comment 2 Halla Rempt 2019-05-13 08:14:49 UTC 
Git commit 1f648b3d36682d2c67fe1f17421e67613d9c0ff7 by Boudewijn Rempt.
Committed on 13/05/2019 at 08:13.
Pushed by rempt into branch 'master'.

Give all PNG brushes a white background

In case they are created with a transparency channel. Qt converts
transparency to black when converting to grayscale.

M  +9    -1    libs/brush/kis_png_brush.cpp

https://invent.kde.org/kde/krita/commit/1f648b3d36682d2c67fe1f17421e67613d9c0ff7
Comment 3 acc4commissions 2019-05-13 09:53:23 UTC 
Created attachment 120034 [details]
Capture 2

Looks like something got wierd on the other side.
Comment 4 Halla Rempt 2019-05-13 10:17:05 UTC 
Did you rebuild Krita? If so, could you share those brushes, because I tested with rgb and grayscale png's, with a white and a transparent backgtround, and all of those worked.
Comment 5 acc4commissions 2019-05-13 10:47:33 UTC 
The brush pack having problem is this one : https://forum.kde.org/viewtopic.php?f=274&t=127423

The files from my system just in case : https://drive.google.com/file/d/1c6F2qwzIwyPcyCLLXmvB0ez6DauYTJx9/view?usp=sharing
Comment 6 Halla Rempt 2019-05-13 11:09:21 UTC 
Git commit ca5aeb769e0db415985b82c7527e45c96f51ec6f by Boudewijn Rempt.
Committed on 13/05/2019 at 11:08.
Pushed by rempt into branch 'master'.

Convert QImage's that cannot be painted on to a format that can be painted on

M  +3    -0    libs/brush/kis_png_brush.cpp

https://invent.kde.org/kde/krita/commit/ca5aeb769e0db415985b82c7527e45c96f51ec6f