| Summary: | Update Xen support to 4.12 and add more coverage | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Tamas K Lengyel <tamas> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark, olaf |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patchfile
Xen 4.13 support |
||
The patch causes the following fall-though warning, and the resulting
merged code does indeed look suspicious. Is this intended? If not
can you make a revised patch?
In file included from m_syswrap/syswrap-xen.c:49:
m_syswrap/syswrap-xen.c: In function ‘vgSysWrap_xen_sysctl_before’:
./pub_core_tooliface.h:50:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
50 | if (VG_(tdict).track_##fn) \
| ^
m_syswrap/priv_types_n_macros.h:618:4: note: in expansion of macro ‘VG_TRACK’
618 | VG_TRACK( pre_mem_read, Vg_CoreSysCall, tid, zzname, zzaddr, zzlen)
| ^~~~~~~~
m_syswrap/syswrap-xen.c:600:7: note: in expansion of macro ‘PRE_MEM_READ’
600 | PRE_MEM_READ("XEN_SYSCTL_" #_sysctl " u." #_union "." #_field, \
| ^~~~~~~~~~~~
m_syswrap/syswrap-xen.c:604:7: note: in expansion of macro ‘__PRE_XEN_SYSCTL_READ’
604 | __PRE_XEN_SYSCTL_READ(_sysctl, _sysctl, _field)
| ^~~~~~~~~~~~~~~~~~~~~
m_syswrap/syswrap-xen.c:640:3: note: in expansion of macro ‘PRE_XEN_SYSCTL_READ’
640 | PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, buffer);
| ^~~~~~~~~~~~~~~~~~~
m_syswrap/syswrap-xen.c:641:7: note: here
641 | case 0x00000010:
| ^~~~
Created attachment 124881 [details]
Xen 4.13 support
Fixed the previous issue reported and a couple additional minor stuff I found. Also updated the support to include the recently released Xen 4.13 version.
Committed, c88133141a354d65568fb85037abc5e1f74ce46b. Thanks for the patch. *** Bug 390553 has been marked as a duplicate of this bug. *** commit c88133141a354d65568fb85037abc5e1f74ce46b Author: Julian Seward <jseward@acm.org> Date: Wed Jan 22 10:55:33 2020 +0100 Bug 407376 - Update Xen support to 4.12 (4.13, actually) and add more covera ge. Patch from Tamas K Lengyel (tamas@tklengyel.com). |
Created attachment 119941 [details] Patchfile SUMMARY The attached patch updates Valgrind's support to Xen 4.12 and adds more coverage, specifically for hypercalls used by introspection tools like LibVMI.