Bug 407372

Summary:	Need help-donate-[currency] icons
Product:	[Plasma] Breeze	Reporter:	Nate Graham <nate>
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a, sitter
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-icons/e759724fab78d5e8ab23637f18fd602825be8303	Version Fixed/Implemented In:	5.59
Sentry Crash Report:

Description Nate Graham 2019-05-09 20:28:14 UTC

A feature is under development that allows the "Donate" menu item to display an icon that depicts the user's own currency. For example a user with the en_US locale would see the icon help-donate-USD, which presumably would have a dollar sign in it.

If no suitable locale-specific icon is available, it falls back to help-donate, which currently depicts a dollar sign. My suggestion is to change that to something more generic and optionally whimsical or amusing, such as a treasure chest or bag of gold coins.

Comment 1 Nate Graham 2019-05-09 20:32:40 UTC

Here are the top 15 currencies used to donate to KDE, which we should aspire to get icons for:

    EUR - Euro
    USD - American Dollar (can use this for AUD and CAD too via symlinks)
    RUB - Russian Ruble
    GBP - Great British Pound
    CNY - Chinese Yuan
    BRR - Brazilian Real
    INR - Indian Rupee
    MXN - Mexican Peso
    PLN - Polish Zloty
    UAH - Ukranian Hryvnia
    TRY - Turkish Lira
    SEK - Swedish Krona
    JPY - Japanese Yen
    ARS - Argentine Peso
    CHF - Swiss Franc

Comment 2 Harald Sitter 2019-05-23 10:39:22 UTC

Please note that the actual icon names are all lower case.

help-donate-eur
help-donate-usd
help-donate-rub
etc.

Comment 3 Noah Davis 2019-06-03 11:51:08 UTC

Git commit e759724fab78d5e8ab23637f18fd602825be8303 by Noah Davis.
Committed on 03/06/2019 at 11:50.
Pushed by ndavis into branch 'master'.

Add help-donate-[currency] icons

Summary:
These are only 16px icons.
According to the bug report, these will be used in the application menu, which shows 16px icons.
22px versions can be added later.
FIXED-IN: 5.59

Test Plan:
{F6863491, size=full}

{F6863492, size=full}

Reviewers: #vdg, sitter, broulik, ngraham

Reviewed By: #vdg, sitter, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21526

A  +1    -0    icons-dark/actions/16/help-donate-ars.svg
A  +1    -0    icons-dark/actions/16/help-donate-aud.svg
A  +11   -0    icons-dark/actions/16/help-donate-brl.svg
A  +1    -0    icons-dark/actions/16/help-donate-cad.svg
A  +8    -0    icons-dark/actions/16/help-donate-chf.svg
A  +1    -0    icons-dark/actions/16/help-donate-cny.svg
A  +11   -0    icons-dark/actions/16/help-donate-eur.svg
A  +8    -0    icons-dark/actions/16/help-donate-gbp.svg
A  +8    -0    icons-dark/actions/16/help-donate-inr.svg
A  +8    -0    icons-dark/actions/16/help-donate-jpy.svg
A  +1    -0    icons-dark/actions/16/help-donate-mxn.svg
A  +11   -0    icons-dark/actions/16/help-donate-pln.svg
A  +8    -0    icons-dark/actions/16/help-donate-rub.svg
A  +13   -0    icons-dark/actions/16/help-donate-sek.svg
A  +11   -0    icons-dark/actions/16/help-donate-try.svg
A  +11   -0    icons-dark/actions/16/help-donate-uah.svg
A  +11   -0    icons-dark/actions/16/help-donate-usd.svg
A  +1    -0    icons/actions/16/help-donate-ars.svg
A  +1    -0    icons/actions/16/help-donate-aud.svg
A  +11   -0    icons/actions/16/help-donate-brl.svg
A  +1    -0    icons/actions/16/help-donate-cad.svg
A  +8    -0    icons/actions/16/help-donate-chf.svg
A  +1    -0    icons/actions/16/help-donate-cny.svg
A  +11   -0    icons/actions/16/help-donate-eur.svg
A  +8    -0    icons/actions/16/help-donate-gbp.svg
A  +8    -0    icons/actions/16/help-donate-inr.svg
A  +8    -0    icons/actions/16/help-donate-jpy.svg
A  +1    -0    icons/actions/16/help-donate-mxn.svg
A  +11   -0    icons/actions/16/help-donate-pln.svg
A  +8    -0    icons/actions/16/help-donate-rub.svg
A  +13   -0    icons/actions/16/help-donate-sek.svg
A  +11   -0    icons/actions/16/help-donate-try.svg
A  +11   -0    icons/actions/16/help-donate-uah.svg
A  +11   -0    icons/actions/16/help-donate-usd.svg

https://commits.kde.org/breeze-icons/e759724fab78d5e8ab23637f18fd602825be8303