Bug 407320

Summary: Crash opening and closing big image.
Product: [Applications] krita Reporter: vanyossi <ghevan>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: backtrace

Description vanyossi 2019-05-08 06:37:27 UTC
Created attachment 119908 [details]
backtrace

Created a blank canvas 9k x 8k, noticed It was 16bit, closed it (to create a new one in 8bit).  crash

The backtrace shows the resource was not available by the time it was asked for.
Comment 1 Halla Rempt 2019-05-08 08:27:25 UTC
Git commit 9810e49fa94f62cb9481b852e29cdd988be5540d by Boudewijn Rempt.
Committed on 08/05/2019 at 08:27.
Pushed by rempt into branch 'master'.

Check whether there's a paintdevice before using it

M  +1    -1    plugins/dockers/histogram/histogramdockerwidget.cpp

https://invent.kde.org/kde/krita/commit/9810e49fa94f62cb9481b852e29cdd988be5540d
Comment 2 Halla Rempt 2019-05-08 08:56:20 UTC
Yes, basically, the histogram docker wanted to repaint itself after the image is already gone. But this was easy -- you could've added that check yourself :P
Comment 3 vanyossi 2019-05-08 15:56:12 UTC
Indeed, When I was reporting I thought "I could fix this before going to sleep", but then I remembered the CPU was building 10 thousand packages and thought "I better report it and come back to it later"
Comment 4 Halla Rempt 2019-05-08 15:57:49 UTC
:P