Bug 407319

Summary: "Tools -> New Window" opens incognito from incognito window
Product: [Applications] Falkon Reporter: Andrew Brouwers <abrouwers>
Component: generalAssignee: David Rosca <nowrep>
Status: CONFIRMED ---    
Severity: normal CC: abogical
Priority: NOR    
Version First Reported In: 3.1.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Andrew Brouwers 2019-05-08 02:50:02 UTC 
SUMMARY
If I'm in an incognito window, I'd expect "Tools -> New Window" to open a regular window, and "Tools -> New Incognito Window" to open an incognito window.  However, both appear to just open an incognito window.

STEPS TO REPRODUCE
1. Open an incognito window
2. Tools -> New Window
3. 

OBSERVED RESULT
New window is "incognito" too


EXPECTED RESULT
A normal window.

SOFTWARE/OS VERSIONS
falkon 3.1.0.66.g3bc0c165-1
qt5-base 5.12.3-2
qt5-declarative 5.12.3-1
qt5-graphicaleffects 5.12.3-1
qt5-location 5.12.3-1
qt5-multimedia 5.12.3-1
qt5-quickcontrols 5.12.3-1
qt5-quickcontrols2 5.12.3-1
qt5-script 5.12.3-1
qt5-sensors 5.12.3-1
qt5-speech 5.12.3-1
qt5-svg 5.12.3-1
qt5-tools 5.12.3-1
qt5-webchannel 5.12.3-1
qt5-webengine 5.12.3-2
qt5-webkit 5.212.0alpha2-28
qt5-x11extras 5.12.3-1
Comment 1 abogical 2020-02-27 01:19:35 UTC 
Confirmed. I'll try working on a patch.
Comment 2 abogical 2020-02-27 02:11:13 UTC 
(In reply to abogical from comment #1)
> Confirmed. I'll try working on a patch.

Awaiting review at https://phabricator.kde.org/D27691