Bug 407269

Summary: Alow deselection by clicking with a selection tool stopped working
Product: [Applications] krita Reporter: Raghavendra kamath <raghu>
Component: Tools/SelectionAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: ghevan, halla
Priority: NOR Keywords: regression
Version: 4.1.7   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/krita/commit/f9c443fa8b4b4ebfcb2aa2d1a3100a060f87fe4e Version Fixed In:
Sentry Crash Report:

Description Raghavendra kamath 2019-05-06 13:42:03 UTC 
SUMMARY
We had a new feature which allowed a user to deselect an existing selection just by clicking on the canvas by any selection tool. This was implemented in the following commit -https://invent.kde.org/kde/krita/commit/2eab134abb0d7031cba5b65ee04bf306b1b47af

But in recent master it has stopped working. Iwill try to bisect and see where this got broken. 

STEPS TO REPRODUCE
1. Open krita built from master
2. make a selection with any selection tool
3. click anywhere in the canvas to deselect the selection

OBSERVED RESULT
selection doesn't get deselected.


EXPECTED RESULT
selection should get deselected on left click

SOFTWARE/OS VERSIONS

Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.3
Comment 1 Halla Rempt 2019-05-09 13:52:06 UTC 
Um, this still works for me?
Comment 2 Raghavendra kamath 2019-05-09 15:55:19 UTC 
(In reply to Boudewijn Rempt from comment #1)
> Um, this still works for me?

Yes I checked only the rectangle and elliptical selection tool deselect on click , but now the outline select and polygon select tool. So this bug report can either be closed or renamed into the following wishbug-

"Make the click to deselect feature available to polygon and outline select tool".
Comment 3 vanyossi 2019-05-10 01:07:25 UTC 
I can see that working for outline selection but not for polygon tool as that would interfere on how the tool expected usage.
Comment 4 Dmitry Kazakov 2019-05-10 13:57:05 UTC 
Git commit 38992f0225df2944173b7280e3dcf5bb83a3841d by Dmitry Kazakov.
Committed on 10/05/2019 at 13:55.
Pushed by dkazakov into branch 'kazakov/hevc-qsv'.

Fix deselection aciton in outlint and polygonal selection tools

M  +7    -4    plugins/tools/selectiontools/kis_tool_select_outline.cc
M  +7    -0    plugins/tools/selectiontools/kis_tool_select_polygonal.cc

https://invent.kde.org/kde/krita/commit/38992f0225df2944173b7280e3dcf5bb83a3841d
Comment 5 Dmitry Kazakov 2019-05-10 14:00:09 UTC 
Git commit f9c443fa8b4b4ebfcb2aa2d1a3100a060f87fe4e by Dmitry Kazakov.
Committed on 10/05/2019 at 13:59.
Pushed by dkazakov into branch 'master'.

Fix deselection aciton in outlint and polygonal selection tools

M  +7    -4    plugins/tools/selectiontools/kis_tool_select_outline.cc
M  +7    -0    plugins/tools/selectiontools/kis_tool_select_polygonal.cc

https://invent.kde.org/kde/krita/commit/f9c443fa8b4b4ebfcb2aa2d1a3100a060f87fe4e