Bug 407257

Summary: Importing GNUcash (Account name instead of AccountID)
Product: [Applications] skrooge Reporter: tiagogr.aca+Sk
Component: generalAssignee: Stephane MANKOWSKI <stephane>
Status: RESOLVED FIXED    
Severity: normal CC: stephane
Priority: NOR    
Version First Reported In: 2.19.0   
Target Milestone: 25.1.0   
Platform: Mint (Debian based)   
OS: Linux   
Latest Commit: https://commits.kde.org/skrooge/1d4148b1001ceab364db657444643dd6f2b2a835 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: GNUCash_EditAccount image
Dummy data from Gnucash (Demo_import.gnucash)
Import_result.skg

Description tiagogr.aca+Sk 2019-05-06 02:32:38 UTC 
SUMMARY
Account name importation from GNUCASH goes in Account instead of ACCOUNTID.



OBSERVED RESULT
When importing a GNUcash file, Skrooge successfully import the accounts and the transactions. When looking at the accounts, Skrooge imported the Account name from GNUCash into the Account in Skrooge.

EXPECTED RESULT
Import Account ID to Account.

SOFTWARE/OS VERSIONS


KDE Frameworks Version: 5.44.0
Qt Version: 5.9.5

ADDITIONAL INFORMATION
Comment 1 Stephane MANKOWSKI 2019-05-07 20:24:55 UTC 
Hi,

I don't understand. In the file, I can see that the act:name is something understandable by end user but act:id is not:
<gnc:account version="2.0.0">
  <act:name>Photo</act:name>
  <act:id type="guid">12b44d582fbc6b1e0b4e68a442bd701a</act:id>

Why should I use act:id instead of act:name?
Could you provide me a simple sample file and the expected behavior?
Regards.
Comment 2 tiagogr.aca+Sk 2019-05-08 01:50:07 UTC 
Created attachment 119902 [details]
GNUCash_EditAccount image
Comment 3 tiagogr.aca+Sk 2019-05-08 01:51:19 UTC 
Created attachment 119903 [details]
Dummy data from Gnucash (Demo_import.gnucash)
Comment 4 tiagogr.aca+Sk 2019-05-08 01:51:53 UTC 
Created attachment 119904 [details]
Import_result.skg
Comment 5 tiagogr.aca+Sk 2019-05-08 01:53:38 UTC 
Sorry the confusion. I wasn't that clear with my submission.
I also used the wrong words. 

Attachments files:
1 - GNUCash_EditAccount.png
2 - Demo_import.gnucash
3 - Import_results.skg

---
Description

Take a look at the GNUCash_EditAccount.png image.

From the image, the section named Account Name (1) is the one that Skrooge imported in the field Account. 
Account Code (2) (In GNUCash) is not imported in the field named « Number » (Skrooge).


I also noticed the import doesn't import accounts without transactions.
Comment 6 Stephane MANKOWSKI 2019-05-08 14:12:32 UTC 
Git commit 1d4148b1001ceab364db657444643dd6f2b2a835 by Stephane MANKOWSKI.
Committed on 08/05/2019 at 14:12.
Pushed by smankowski into branch 'master'.

Importing GNUcash (Account name instead of AccountID)

M  +3    -0    CHANGELOG
M  +1    -0    README
M  +8    -3    plugins/import/skrooge_import_gnc/skgimportplugingnc.cpp
A  +-    --    tests/input/skgtestimportgnucash/407257.gnucash
M  +31   -1    tests/skgbankmodelertest/skgtestimportgnucash.cpp

https://commits.kde.org/skrooge/1d4148b1001ceab364db657444643dd6f2b2a835