Bug 406940

Summary:	Consider reducing the size of the busy indicator in views
Product:	[Applications] Elisa	Reporter:	David K <nilsolm>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://commits.kde.org/elisa/bc9b05ca4e555e19e07340cb6122e9cd63a37d26	Version Fixed/Implemented In:
Sentry Crash Report:

Description David K 2019-04-26 22:39:27 UTC

Currently (latest version from git), the busy indicator will fill the entire middle panel when loading data (which seems to happen every time you switch between different views). A smaller indicator would look better, in my opinion.

FWIW, I did tinker with the code a bit and found that centering the indicator in the panel with anchors.centerIn instead of anchors.fill is visually more pleasing. I can't really make screenshots for comparison though, because the thing disappears too fast.

Comment 1 Matthieu Gallien 2019-04-28 09:32:13 UTC

Thanks for your report.
Could you try to submit it to phabricator ?
You can also add a small code tweak to have it shown longer.

Comment 2 David K 2019-04-28 10:37:03 UTC

I haven't used Phabricator before, but I'll look into it later today.

Comment 3 Matthieu Gallien 2019-04-30 15:40:59 UTC

Git commit bc9b05ca4e555e19e07340cb6122e9cd63a37d26 by Matthieu Gallien, on behalf of David Koermendi.
Committed on 30/04/2019 at 15:40.
Pushed by mgallien into branch '0.4'.

Reduce the size of busy indicators

Summary:
As reported in 406940, the busy indicators that show up when data is being loaded are a bit too big at the moment. These changes reduce their size by anchoring them at the center instead of having them fill the available space (see example screenshots below for comparison).

Track view before change:
{F6798571}

Track view after change:
{F6798572}

Grid view before change:
{F6798574}

Grid view after change:
{F6798575}

Test Plan: This is just a minor UI tweak. No behavioural changes.

Reviewers: #elisa, mgallien, #vdg, ngraham

Reviewed By: #elisa, mgallien, #vdg, ngraham

Subscribers: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D20880

M  +5    -2    src/qml/AlbumView.qml
M  +5    -2    src/qml/DataGridView.qml
M  +5    -2    src/qml/FrequentlyPlayedTracks.qml
M  +6    -2    src/qml/GridBrowserDelegate.qml
M  +5    -2    src/qml/RecentlyPlayedTracks.qml
M  +5    -2    src/qml/TracksView.qml

https://commits.kde.org/elisa/bc9b05ca4e555e19e07340cb6122e9cd63a37d26