Bug 406903

Summary: no message when Skrooge can't open .skg file given on command line
Product: [Applications] skrooge Reporter: skierpage <info>
Component: generalAssignee: Stephane MANKOWSKI <stephane>
Status: RESOLVED FIXED    
Severity: minor CC: stephane
Priority: NOR    
Version First Reported In: Trunk from git   
Target Milestone: 25.1.0   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://commits.kde.org/skrooge/d738185599e84a4ab5ba037c28b0f09f0bed0545 Version Fixed/Implemented In:
Sentry Crash Report:

Description skierpage 2019-04-25 23:09:02 UTC 
SUMMARY
Skrooge silently fails if you specify an invalid path to skg file on command line. If I'm not paying attention I won't notice right away.

STEPS TO REPRODUCE
1. In a terminal, enter `skrooge junk.skg`

OBSERVED RESULT
No red error message, no red bar across the top.
The page footer displays "Categories imported." (huh?) instead of "File '/path/to/good.skg' opened."

If I turn on tracing, the console output has one ERR,
  ##      <virtual SKGError SKGDocument::getMessages(int, SKGDocument::SKGMessageList&, bool) RC=[ERR-3]: No database defined

EXPECTED RESULT
See the same red
  [ERR-NN]: Failed to open '/full/path/to/junk.skg'.
message in the messages pane and across the top that Skrooge displays if I enter an invalid badfilename.skg in its File > Open... dialog.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.55.0
Qt Version: 5.11.3
Comment 1 Stephane MANKOWSKI 2019-04-26 16:39:04 UTC 
Git commit d738185599e84a4ab5ba037c28b0f09f0bed0545 by Stephane MANKOWSKI.
Committed on 26/04/2019 at 16:37.
Pushed by smankowski into branch 'master'.

no message when Skrooge can't open .skg file given on command line

M  +1    -0    CHANGELOG
M  +12   -8    plugins/generic/skg_file/skgfileplugin.cpp

https://commits.kde.org/skrooge/d738185599e84a4ab5ba037c28b0f09f0bed0545
Comment 2 Stephane MANKOWSKI 2019-04-26 16:39:56 UTC 
Hi skierpage,

Because you are working a lot to improve Skrooge, I added your nickname in the "About" of Skrooge.

Regards.