Bug 406902

Summary: sieveeditor crash on start
Product: [Applications] sieveeditor Reporter: Rex Dieter <rdieter>
Component: generalAssignee: Laurent Montel <montel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://commits.kde.org/pim-sieve-editor/b8fa64aba773fa2266036042b18e78e5d9e761bc Version Fixed In: 5.11.1
Sentry Crash Report:
Attachments: Don't try to setEnabled mShareAction if it's not initialized

Description Rex Dieter 2019-04-25 21:11:47 UTC 
Experiencing on Fedora 30, sieveeditor crashes on start.

See also downstream report,
https://bugzilla.redhat.com/show_bug.cgi?id=1670396

Kcrash report below

Application: KSieve Editor (sieveeditor), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f22dde62980 (LWP 14707))]

Thread 5 (Thread 0x7f22c35ef700 (LWP 14711)):
#0  0x00007f22e9a53f2d in g_mutex_lock () from /lib64/libglib-2.0.so.0
#1  0x00007f22e9a07877 in g_main_context_prepare () from /lib64/libglib-2.0.so.0
#2  0x00007f22e9a0820b in ?? () from /lib64/libglib-2.0.so.0
#3  0x00007f22e9a08413 in g_main_context_iteration () from /lib64/libglib-2.0.so.0
#4  0x00007f22eb5b7543 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5
#5  0x00007f22eb56141b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5
#6  0x00007f22eb3ba745 in QThread::exec() () from /lib64/libQt5Core.so.5
#7  0x00007f22eb3bb8a6 in ?? () from /lib64/libQt5Core.so.5
#8  0x00007f22ea4295a2 in start_thread () from /lib64/libpthread.so.0
#9  0x00007f22eb03c023 in clone () from /lib64/libc.so.6

Thread 4 (Thread 0x7f22c8b8d700 (LWP 14710)):
#0  0x00007f22eb0312b7 in poll () from /lib64/libc.so.6
#1  0x00007f22e9a082de in ?? () from /lib64/libglib-2.0.so.0
#2  0x00007f22e9a08413 in g_main_context_iteration () from /lib64/libglib-2.0.so.0
#3  0x00007f22eb5b7543 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5
#4  0x00007f22eb56141b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5
#5  0x00007f22eb3ba745 in QThread::exec() () from /lib64/libQt5Core.so.5
#6  0x00007f22ea459f3b in ?? () from /lib64/libQt5DBus.so.5
#7  0x00007f22eb3bb8a6 in ?? () from /lib64/libQt5Core.so.5
#8  0x00007f22ea4295a2 in start_thread () from /lib64/libpthread.so.0
#9  0x00007f22eb03c023 in clone () from /lib64/libc.so.6

Thread 3 (Thread 0x7f22ca7cc700 (LWP 14709)):
#0  0x00007f22ea42f4e5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f22cb3cb54b in ?? () from /usr/lib64/dri/i965_dri.so
#2  0x00007f22cb3cb28b in ?? () from /usr/lib64/dri/i965_dri.so
#3  0x00007f22ea4295a2 in start_thread () from /lib64/libpthread.so.0
#4  0x00007f22eb03c023 in clone () from /lib64/libc.so.6

Thread 2 (Thread 0x7f22d0c02700 (LWP 14708)):
#0  0x00007f22eb0312b7 in poll () from /lib64/libc.so.6
#1  0x00007f22e999a38a in ?? () from /lib64/libxcb.so.1
#2  0x00007f22e999bffa in xcb_wait_for_event () from /lib64/libxcb.so.1
#3  0x00007f22d0d64918 in ?? () from /lib64/libQt5XcbQpa.so.5
#4  0x00007f22eb3bb8a6 in ?? () from /lib64/libQt5Core.so.5
#5  0x00007f22ea4295a2 in start_thread () from /lib64/libpthread.so.0
#6  0x00007f22eb03c023 in clone () from /lib64/libc.so.6

Thread 1 (Thread 0x7f22dde62980 (LWP 14707)):
[KCrash Handler]
#6  0x00007f22ebeb9ce9 in QAction::setEnabled(bool) () from /lib64/libQt5Widgets.so.5
#7  0x00007f22ec52040a in SieveEditorMainWindow::slotUpdateActions (this=0x555a825dcc10) at /usr/src/debug/pim-sieve-editor-18.12.2-1.fc30.x86_64/src/sieveeditormainwindow.cpp:372
#8  0x00007f22ec520aa3 in SieveEditorMainWindow::slotSystemNetworkOnlineStateChanged (this=this@entry=0x555a825dcc10, state=<optimized out>) at /usr/src/debug/pim-sieve-editor-18.12.2-1.fc30.x86_64/src/sieveeditormainwindow.cpp:103
#9  0x00007f22ec5250c2 in SieveEditorMainWindow::SieveEditorMainWindow (this=0x555a825dcc10, parent=<optimized out>, __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at /usr/src/debug/pim-sieve-editor-18.12.2-1.fc30.x86_64/src/sieveeditormainwindow.cpp:70
#10 0x0000555a81ee8891 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/pim-sieve-editor-18.12.2-1.fc30.x86_64/src/main.cpp:62
[Inferior 1 (process 14707) detached]
Comment 1 Rex Dieter 2019-04-25 21:15:06 UTC 
Created attachment 119639 [details]
Don't try to setEnabled mShareAction if it's not initialized

It only gets properly initialized conditionally (depending on
purposeMenu, earlier in the same file), if that didn't happen,
we shouldn't try to do setEnabled (or anything else) to it as
in that case it's a null pointer and this will crash.
Comment 2 Laurent Montel 2019-04-25 21:22:08 UTC 
Git commit b8fa64aba773fa2266036042b18e78e5d9e761bc by Laurent Montel.
Committed on 25/04/2019 at 21:21.
Pushed by mlaurent into branch 'Applications/19.04'.

Fix Bug 406902 - sieveeditor crash on start

FIXED-IN: 5.11.1

M  +3    -1    src/sieveeditormainwindow.cpp

https://commits.kde.org/pim-sieve-editor/b8fa64aba773fa2266036042b18e78e5d9e761bc
Comment 3 Laurent Montel 2019-04-25 21:23:38 UTC 
Sorry I didn't see the patch attached.
I just read the backtrace.
Indeed patch was ok.