Summary: | Tab does not indicate terminal activity in any way | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA> |
Component: | tabbar | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bjoernv, bugzilla-kde, cade.robinson, chris-hartmann, dura, egdfree, gaaf, Hi-Angel, home, mglb, nucleo, petr.velan, rdieter, tcanabrava, wk |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 | Version Fixed In: | 19.12.0 |
Description
Arfrever Frehtes Taifersar Arahesis
2019-04-23 20:04:58 UTC
This problem was introduced in commit 4cddc420e319686956446da2724a27a672817ff1: https://cgit.kde.org/konsole.git/commit/?id=4cddc420e319686956446da2724a27a672817ff1 commit 4cddc420e319686956446da2724a27a672817ff1 Author: Tomaz Canabrava <tcanabrava@kde.org> AuthorDate: 2019-03-28 09:27:15 -0400 Commit: Kurt Hindenburg <kurt.hindenburg@gmail.com> CommitDate: 2019-03-28 09:50:38 -0400 Simplify TerminalDisplay code Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D20088 (In reply to Arfrever Frehtes Taifersar Arahesis from comment #4) > This problem was introduced in commit > 4cddc420e319686956446da2724a27a672817ff1 I have been deceived by https://cgit.kde.org/konsole.git/log/?h=master showing commits from all branches (not only "master" branch) (while e.g. https://cgit.kde.org/konsole.git/log/?h=Applications/19.04 shows commits from only "Applications/19.04" branch). This problem was introduced in commit 6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7: https://cgit.kde.org/konsole.git/commit/?id=6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7 commit 6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7 (refs/git-r3/kde-apps/konsole/5/__main__) Author: Tomaz Canabrava <tcanabrava@kde.org> AuthorDate: 2019-03-26 21:33:09 -0400 Commit: Kurt Hindenburg <kurt.hindenburg@gmail.com> CommitDate: 2019-03-26 21:50:18 -0400 Multiple Splits per Tab Summary: This is what I envision for the Konsole Tab / Splits management. One tab contain a QSPlitter that can contain multiple TerminalDisplays / Splits. You can test this behavior by hitting ctrl + shift + 9 and ctrl + shift + 0 to activate the splits, and ctrl + shift + t to activate a new tab. Old: {F6484123} New: {F6484124} What works: - Tab Creation - Split Creation (Even Recursive splitting) - Terminal Close will close the Split on last split - Last last split to close will close the tab - Last tab to close will close konsole - Detaching - Tab Renaming - Closing splits after detach - Closing windows after detach - Detach / Reattach works! This patch series has the commits of Thomas Surrel, Maciej Niedbdalski and Myself. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: luc4, hallas, anthonyfieroni, gennad, ngraham, thsurrel, maciejn, mglb, hindenburg, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D17643 *** Bug 410142 has been marked as a duplicate of this bug. *** *** Bug 411991 has been marked as a duplicate of this bug. *** *** This bug has been confirmed by popular vote. *** I've sent a simple fix to this problem to the mailing list. (In reply to Petr Velan from comment #7) > I've sent a simple fix to this problem to the mailing list. What is "the" mailing list? Why not make the patch available for everyone interested in a fix for this issue? Maybe you can attach the patch here or push it to phabricator.kde.org. (In reply to Alex Hermann from comment #8) > (In reply to Petr Velan from comment #7) > > I've sent a simple fix to this problem to the mailing list. > > What is "the" mailing list? > > Why not make the patch available for everyone interested in a fix for this > issue? Maybe you can attach the patch here or push it to phabricator.kde.org. This mailing list: https://mail.kde.org/mailman/listinfo/konsole-devel It seemed quite complicated to setup an account and create a patch using phabricator for such a simple patch. Anyway, since nobody responded to me for some time, I've tried to submit the patch using the phabricator web: https://phabricator.kde.org/D25151 Git commit 69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 by Kurt Hindenburg, on behalf of Petr Velan. Committed on 07/11/2019 at 15:08. Pushed by hindenburg into branch 'master'. Fix tabs not indicating activity Summary: This fixes the bug with tabs not indicating terminal activity. When the tab is split and has multiple child terminals, activity in any of the child terminals will be indicated. FIXED-IN: 19.12.0 Test Plan: Open two tabs, run `sleep 2` in the first one and switch to the other. After the sleep ends, the tab activity is indicated just as it was before the bug was introduced. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D25151 M +3 -1 src/ViewContainer.cpp https://invent.kde.org/kde/konsole/commit/69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 Git commit 69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 by Kurt Hindenburg, on behalf of Petr Velan. Committed on 07/11/2019 at 15:08. Pushed by scmsync into branch 'master'. Fix tabs not indicating activity Summary: This fixes the bug with tabs not indicating terminal activity. When the tab is split and has multiple child terminals, activity in any of the child terminals will be indicated. FIXED-IN: 19.12.0 Test Plan: Open two tabs, run `sleep 2` in the first one and switch to the other. After the sleep ends, the tab activity is indicated just as it was before the bug was introduced. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D25151 M +3 -1 src/ViewContainer.cpp https://commits.kde.org/konsole/69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 |