Bug 406722

Summary:	KUserFeedback is not included in Frameworks group
Product:	[Developer tools] kdesrc-build	Reporter:	Juan Carlos Torres <carlosdgtorres>
Component:	project metadata	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	bcooksley
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Juan Carlos Torres 2019-04-21 02:48:21 UTC

SUMMARY

KUserFeedback is not included in the Frameworks group. It was added to KDE Frameworks around 2017 but kde-build-metadata still lists it under Extragear

STEPS TO REPRODUCE
1. Run kdesrc-build frameworks --list-build

OBSERVED RESULT

kuserfeedback isn't included in the list.

EXPECTED RESULT

kuserfeedback should be built and installed like any other framework.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon Testing
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0

Comment 1 Michael Pyne 2019-04-27 16:46:33 UTC

The metadata used to figure out if KUserFeedback is a framework at all should actually be sysadmin/repo-management. The metadata used to find dependencies for KUserFeedback would be in kde-build-metadata. (Long story)

I'll look into this, if those metadata sets are inconsistent it wouldn't surprise me if it causes issues elsewhere.

Comment 2 Michael Pyne 2019-04-27 19:19:33 UTC

Juan, I took a look at sysadmin/repo-metadata and it seems that kuserfeedback is part of extragear/libs. So from that perspective kdesrc-build is doing the right thing.

I know there's been a module or two over time that have been developed outside of kde/frameworks while they were getting into shape for KF5, but I'm not aware of any that were deliberately left outside of kde/frameworks/* even while they were meant to be treated as a part of KF5.

Ben might know more, I've CC'ed him. But if KUserFeedback is meant to be part of KF5 then I would recommend asking its maintainer to work with kde-frameworks-devel to get the module proposed for and approved for inclusion into KF5, and from there the sysadmins can update sysadmin/repo-metadata.

If KUserFeedback is required for kdesrc-build in the meantime, then a module-set config like this would work, and could be made part of the sample and generated configuration files:

    module-set kf5-frameworks
        repository  kde-projects
        use-modules frameworks kuserfeedback
    end module-set

However note that kuserfeedback does not presently contain any dependency data within kde-build-metadata, that's another thing that would need to be fixed to work well with kdesrc-build and build.kde.org

Comment 3 Ben Cooksley 2019-04-27 20:37:01 UTC

As far as I am aware, KUserFeedback isn't considered part of Frameworks. It most certainly isn't being released as part of Frameworks, given it lacks tarballs at https://download.kde.org/stable/frameworks/5.57/

Comment 4 Juan Carlos Torres 2019-04-27 23:02:55 UTC

OK, that's rather confusing. But I guess the bug is in KUserFeedback then. I merely based it on the framework being listed as part of https://api.kde.org/frameworks/index.html which is probably because https://cgit.kde.org/kuserfeedback.git/tree/metainfo.yaml claims it's a framework. I wasn't aware it was part of extragear (partly due to cgit's flat structure, I didn't know where to  check for that info, will look into it).

Thanks for the response and apologies for the noise. :D

Comment 5 Ben Cooksley 2019-04-28 06:54:34 UTC

No worries - the issue with it showing up on api.kde.org under Frameworks will likely be rectified once the new infrastructure for generating it has been finalised.