Bug 406678

Summary: Button to install local package is missing in mobile mode until you maximize and unmaximize the window
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: admin, aleixpol
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: screenshot - button to install the package is missing
screenshot - the button appears after you maximize and unmaximize discover

Description Patrick Silva 2019-04-19 13:40:27 UTC
Created attachment 119501 [details]
screenshot - button to install the package is missing

STEPS TO REPRODUCE
1. open discover and decrease its window size until the mobile mode to be activated
2. close discover
3. open a local (deb/rpm) package with discover

OBSERVED RESULT
As we can see in attached screenshot, there is no button to install the local package. Such button appears after you maximize and unmaximize discover.

EXPECTED RESULT
the button to install a local package is always available in mobile mode.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 1 Patrick Silva 2019-04-19 13:41:13 UTC
Created attachment 119502 [details]
screenshot - the button appears after you maximize and unmaximize discover
Comment 2 Dan Leinir Turthra Jensen 2019-04-23 07:54:14 UTC
i also notice in the screenshots that the context drawer is missing in the first and appears in the second, which might suggest what's happening here is that the current page is not correct until the resize event happens.
Comment 3 Aleix Pol 2019-04-23 16:04:04 UTC
Should be fixed by https://phabricator.kde.org/D20771
Comment 4 Aleix Pol 2019-04-23 16:08:30 UTC
Git commit 94b8482946dbc24ae79aa2d60dff4a44600bd2b9 by Aleix Pol.
Committed on 23/04/2019 at 16:06.
Pushed by apol into branch 'master'.

Make sure we don't squeeze out the ActionButton

Summary:
Use the implicit height to set its height, we're using it to put it on its Loader. This would sometimes resize the Buttons to 0 and we just wouldn't get any buttons at all.

Reviewers: mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D20771

M  +1    -1    src/controls/Page.qml
M  +1    -1    src/controls/private/ActionButton.qml

https://commits.kde.org/kirigami/94b8482946dbc24ae79aa2d60dff4a44600bd2b9
Comment 5 Aleix Pol 2019-04-23 22:46:10 UTC
What Dan mentions is something still to be looked into, it's just a different (similar?) issue.