Bug 406666

Summary: Split sentences on "colorspaceconversion.cc"
Product: [Applications] krita Reporter: Sabri Ünal <libreajans>
Component: TranslationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/krita/commit/471ea1b1072107ec11ed0f9ca4fbd2ddaa2fb5dd Version Fixed/Implemented In:
Sentry Crash Report:

Description Sabri Ünal 2019-04-18 23:15:37 UTC 
There are two split sentences on the colorspaceconversion.cc file. (plugins/extensions/colorspaceconversion/colorspaceconversion.cc).

To make a proper translation there must be a %1 mark.

>> dlgColorSpaceConversion->setCaption(i18n("Convert All Layers From ") + image->colorSpace()->name());

>> dlgColorSpaceConversion->setCaption(i18n("Convert Current Layer From") + layer->colorSpace()->name());

OBSERVED RESULT

#: plugins/extensions/colorspaceconversion/colorspaceconversion.cc:79
msgid "Convert All Layers From "

#: plugins/extensions/colorspaceconversion/colorspaceconversion.cc:108
msgid "Convert Current Layer From"

EXPECTED RESULT

#: plugins/extensions/colorspaceconversion/colorspaceconversion.cc:79
msgid "Convert All Layers From %1"

#: plugins/extensions/colorspaceconversion/colorspaceconversion.cc:108
msgid "Convert Current Layer From %1"


SOFTWARE/OS VERSIONS

Krita

 Version: 4.2.0-pre-alpha
 Languages: en
 Hidpi: true

Qt

  Version (compiled): 5.9.5
  Version (loaded): 5.9.5

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.15.0-48-lowlatency
  Pretty Productname: Ubuntu 18.04.2 LTS
  Product Type: ubuntu
  Product Version: 18.04
Comment 1 Halla Rempt 2019-04-18 23:24:51 UTC 
Git commit 471ea1b1072107ec11ed0f9ca4fbd2ddaa2fb5dd by Boudewijn Rempt.
Committed on 18/04/2019 at 23:24.
Pushed by rempt into branch 'master'.

Fix translatable strings

M  +2    -2    plugins/extensions/colorspaceconversion/colorspaceconversion.cc

https://invent.kde.org/kde/krita/commit/471ea1b1072107ec11ed0f9ca4fbd2ddaa2fb5dd