Bug 406603

Summary:	Undo message should only appear when the playlist was explicitly cleared by the user
Product:	[Applications] Elisa	Reporter:	Nate Graham <nate>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	minor	CC:	bugseforuns
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/elisa/ae0be3899c10908be4066aed089f5c88f5b78bdc	Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2019-04-16 16:16:37 UTC

Right now the "playlist cleared" undo message appears when the playlist gets cleared for any reason--including after clicking on the "replace and play" button.

I click on this button a lot and so I see the undo message a lot, and it seems sort of annoying and non-useful.

I would recommend only showing the message whe the playlist is cleared as a result of the user explicitly clicking on the Clear Playlist button.

Alternatively, or in addition, maybe the message should time out after a few seconds? Usually this is a bad UI, but it might be appropriate here if it's going to be something the user sees all the time.

Comment 1 Matthieu Gallien 2019-04-16 16:30:37 UTC

My idea was that you could accidentally click on the wrong button. In this case, the application will let you lose your work and does not help you. In other words, it will make you stupid!

Comment 2 Nate Graham 2019-04-16 16:53:53 UTC

Yeah, I don't object to the idea of an Undo. However this one is kind of in-your-face. I think that's fine to a point, but when you see it all the time, it gets kind of annoying. At least for me.

The way a lot of mobile email apps implement something like this is that after you delete an email, a little unto bar on the bottom shows up just like Elisa now has now, but it disappears after a few seconds. If it stayed around forever, that would be quite irritating, but disappearing after a few seconds makes for a more pleasant user experience IMO.

Comment 3 Matthieu Gallien 2019-04-18 15:32:16 UTC

(In reply to Nate Graham from comment #2)
> Yeah, I don't object to the idea of an Undo. However this one is kind of
> in-your-face. I think that's fine to a point, but when you see it all the
> time, it gets kind of annoying. At least for me.
> 
> The way a lot of mobile email apps implement something like this is that
> after you delete an email, a little unto bar on the bottom shows up just
> like Elisa now has now, but it disappears after a few seconds. If it stayed
> around forever, that would be quite irritating, but disappearing after a few
> seconds makes for a more pleasant user experience IMO.

Do you think that would be enough to make it not too obtrusive ?

I can push a path to do that.

Comment 4 Matthieu Gallien 2019-04-18 15:41:35 UTC

I have pushed this diff request.

Comment 5 Nate Graham 2019-04-18 17:35:08 UTC

(Patch is https://phabricator.kde.org/D20670)

Comment 6 Matthieu Gallien 2019-04-26 06:51:05 UTC

Git commit ae0be3899c10908be4066aed089f5c88f5b78bdc by Matthieu Gallien.
Committed on 26/04/2019 at 06:50.
Pushed by mgallien into branch '0.4'.

automatically hide undo notification 3 seconds after it has been shown

Summary:
A timer is used to automatically hide the notification 3 seconds after it is being shown.

The duration is currently not user configurable.

Test Plan: 3 seconds after it is being shown, the notification is automatically removed

Reviewers: #elisa, ngraham

Reviewed By: ngraham

Subscribers: shubham, pino

Differential Revision: https://phabricator.kde.org/D20670

M  +17   -0    src/qml/MediaPlayListView.qml

https://commits.kde.org/elisa/ae0be3899c10908be4066aed089f5c88f5b78bdc