Bug 406587

Created attachment 119474 [details]
Example where autodrop stops

At this point if I double-click the nine of spades, the rest completes automatically without stopping.
I had not used undo in this game.

Created attachment 119476 [details]
SAved Freecell game with stuck autodrop

This saved game is stuck with it's autodrop.

I had to 'restart' autodrop by clicking on a card four times after this point.

Shlomi is this related to the changes you made to the solver?

Hi!

Thanks for the report and the testcase. Here is a proposed fix patch:

https://phabricator.kde.org/D20720

There also seems to be an issue where loading the game is very slow now.

Also see https://phabricator.kde.org/D20721

Sorry, how do I install this patch? I normally just download the latest version from the Arch Linux repositories.

(In reply to Duncan Kinnear from comment #6)
> Sorry, how do I install this patch? I normally just download the latest
> version from the Arch Linux repositories.

See https://kde.org/applications/games/kpatience/development and https://community.kde.org/Guidelines_and_HOWTOs/CMake .

*** Bug 407080 has been marked as a duplicate of this bug. ***

Ubuntu 19.04 (Disco Dingo) shows this behavior, also.  Autodrop works correctly in other games, only Freecell seems to be affected.

(In reply to Jim Sanderson from comment #9)
> Ubuntu 19.04 (Disco Dingo) shows this behavior, also.  Autodrop works
> correctly in other games, only Freecell seems to be affected.

Actually, Simple Simon doesn't autodrop the completed suit stacks at all any more, but that's been reported in another bug report.

And I've just experienced "Forty & Eight" not auto-completing either, when I got to within about 10 cards from the end. Had to double-click each card except the last one.

I've seen auto drop repeated fizzle out on freecell, and AFAIK, only since
( at least WRT the Linux distro. I'm using ) it *seems* that there has been a
separate library for the freecall solver:

I.E., when running this command
    ldd /usr/bin/kpat | fgrep -i solv
this is the output:

libfreecell-solver.so.0 => /usr/lib64/libfreecell-solver.so.0 (0x00007fc93880c000)

All of you having this problem, can you try the flathub version of kpat https://flathub.org/apps/details/org.kde.kpat and see if you can still reproduce the issue?

Ran all updates.
Uninstalled kpat through synaptic.
Rebooted.
Discoverer shows all up to date.
Installed from Flathub.
"Aborted due to failure."

KDE Plasma version: 5.17.5
KDE Frameworks version: 5.66.0
Qt Version: 5.12.4
Kernel Version: 5.3.0-29 generic
OS Type: 64-bit

Processors: 4 x AMD A10-7700K Radeon R7, 10 Computer Cores 4C+6G
Memory: 6.8 GiB of RAM (8GB physically installed).

Can you please be more specific?

What gives the "Aborted due to failure." error?

(In reply to Albert Astals Cid from comment #15)
> Can you please be more specific?
> 
> What gives the "Aborted due to failure." error?

Simply clicking on the install button.  No other action.  It never finishes.  I have tried it three times now with the same error.  There is no option to see any further information.

I tried it again just now.

1. Went to https://flathub.org/apps/details/org.kde.kpat.
2. Clicked on the "Install" button.
3. Chose "Open with Discoverer".
4. Clicked on "Install" button.
5. Shows 100% on progress bar.
6. Flashes "Aborted due to failure" box for about 5 seconds, then it fades.

That's it.

Here's some other info that may help (or not)...

flatpak: 1.4.3-1
Plasma-discover-flatpak-backend: 5.17.5-Oubuntu1~ubuntu19.10~ppa1
flatpak-xdg-utils-tests: 1.0.0.1
xdg-desktop-portal: 1.4.2-2

That'd be a bug somewhere else. 

For the sake of this bug report maybe install using the command line as described in the flathub web?

(In reply to Albert Astals Cid from comment #17)
> That'd be a bug somewhere else. 
> 
> For the sake of this bug report maybe install using the command line as
> described in the flathub web?
Autodrop appears to work fine now.

Removed Kpat and walked through adding the flatpak stuff.
Barfed with the same "Abort due to error".
This solved the abort error: https://forum.kde.org/viewtopic.php?f=309&t=163844#

Installing via flatpak after that went without error.

Is this the correct version?:

KPatience 19.12.2
KDE Frameworks 5.66.0
Qt 5.13.2

Tried Freecell only.  Will try other games as I have time.

That version sounds correct

Tried to make use of https://flathub.org/apps/details/org.kde.kpat

I encountered multiple sets of information on how to approach that.
The following seemed to more or less work.
===================================================================
# flatpak install org.kde.kpat
Looking for matches…
Found similar ref(s) for ‘org.kde.kpat’ in remote ‘flathub’ (system).
Use this remote? [Y/n]: Y
Required runtime for org.kde.kpat/x86_64/stable (runtime/org.kde.Platform/x86_64/5.13) found in remote flathub
Do you want to install it? [Y/n]: Y

org.kde.kpat permissions:
    ipc     wayland     x11     dri     file access [1]     dbus access [2]

    [1] xdg-config/kdeglobals:ro
    [2] com.canonical.AppMenu.Registrar


        ID                                             Arch              Branch            Remote            Download
 1. [✓] org.kde.Platform                               x86_64            5.13              flathub             306.2 MB / 322.2 MB
 2. [✓] org.freedesktop.Platform.GL.default            x86_64            19.08             flathub              92.6 MB / 92.6 MB
 3. [✗] org.freedesktop.Platform.openh264              x86_64            19.08             flathub           < 593.4 kB
 4. [✓] org.kde.KStyle.Adwaita                         x86_64            5.13              flathub               5.8 MB / 5.8 MB
 5. [✓] org.kde.Platform.Locale                        x86_64            5.13              flathub              16.8 kB / 337.0 MB
 6. [✓] org.kde.kpat                                   x86_64            stable            flathub              14.9 MB / 15.0 MB
 7. [✓] org.kde.kpat.Locale                            x86_64            stable            flathub               4.3 kB / 427.6 kB

Warning: org.freedesktop.Platform.openh264 needs a later flatpak version
Installation complete.
# 
========================================================================
I would expect that as long as the movement of cards was visible,
the h264 not updating wouldn't be much if an issue.

In any event, the auto drop still fizzles out.

If I did something wrong, please let me know so I can try it differently.

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

See comment #18.  The flatpak version works for me.

With the flatpak version the autodrop still fizzles out for me with Freecell.
It appears that the error might have been introduced around the time the
freecell-solver seems to have been split off from the other code.

With so many people stuck at home, it seems like fixing this could be one
of the most solemn responsibilities for KDE right now.  ;-)

(In reply to Anon3141592653 from comment #23)
> With the flatpak version the autodrop still fizzles out for me with Freecell.
> It appears that the error might have been introduced around the time the
> freecell-solver seems to have been split off from the other code.
> 
> With so many people stuck at home, it seems like fixing this could be one
> of the most solemn responsibilities for KDE right now.  ;-)

Hi AnonPi!

Can you provide a saved game *.kpat file that reproduces the issue? Also which OS are you using the flatpak on?

Seems to work for everyone now