| Summary: | Unable to edit vector selections with Edit Shapes Tool | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Tools/Vector | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | dimula73, ghevan, griffinvalley, halla, scottpetrovic |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Video showing vector editing working. | ||
|
Description
Tyson Tan
2019-04-13 08:03:42 UTC
I can confirm the regression. And... It happened not because of any changes in our own code, but because of the update to Qt 5.12. I have guessed it too. Qt 5.12.x is truly the kind of gift that keeps giving. :P This actually still works for me, and I am building with qt 5.12.0 Maybe it's one of the bugfixes that got in that carries its own bugs. Curious, since I am also building and testing against 5.12.0 from my distribution, without any patches. Created attachment 119464 [details]
Video showing vector editing working.
Attaching a video showing vector selections working.
There might be two issues that I can find:
1. It is not obvious when a selection is a vector or raster selection, and raster selections cannot be edited with the edit-shapes-tool.
2. The edit-shapes-tool cannot be used to select vector objects than are part of a selection. You will need to first select a vector object on a selection layer with the select-shapes-tool.
Hi Wolthera, from your video, the Krita build you used is obviously different than mine. 1) Your Krita has a "Edit Selection" item in the Transform Tool's context menu. This is not available in mine. 2) In fact, the Bezier Curve Selection Tool has no context menu at all on my machine, regardless of what build I use, whether it is the stable appimage, nightly appimage or the distro's build. But every other selection tool has a proper context menu (none of them has Edit Selection, BTW) 2) I'm 100% sure the selection I create is vector, not only because I deliberately chose vector mode in the Tool Options, but it is also proven by editing it with the Edit Shape Tool. However, I can only do that with the stable appimage (krita-4.1.7-x86_64.appimage). Not with Krita 4.1.8 from my distribution which has Qt 5.12.2. I think that is really telling something. 3) With krita-4.1.7-x86_64.appimage, I can just click on a vector selection with the Edit Shapes Tool. It is quite straight forward. I can't do that with the current nightly appimage or the distro's build. Maybe the vector selections are different with what we are talking about. Vector selections were completely reworked in Krita 4.2. Tyson -- is there a way you could try out 4.2 and let us know? Maybe the nightly appimage is not 4.2? (In reply to Scott Petrovic from comment #8) > Maybe the vector selections are different with what we are talking about. > Vector selections were completely reworked in Krita 4.2. > > Tyson -- is there a way you could try out 4.2 and let us know? Maybe the > nightly appimage is not 4.2? I don't think we are talking about different things, but rather the thing being positively broken at the moment, while it is probably not our fault. Here is the working/broken list against Qt: krita-4.1.7-x86_64.appimage (Qt 5.9) [WORKING] krita-4.1.8 Manjaro distro (Qt 5.12.2) [BROKEN] krita-4.2.0-pre-alpha-2ef3036a-x86_64.appimage (Qt 5.12) [BROKEN] krita-4.2.0-pre-alpha-1fd8aa7-x86_64.appimage (Qt 5.12) [BROKEN] I think it's really hard not to suspect Qt on this one. This doesn't work on any Krita version on macOS :/ Hi, Tyson! As could you make a video of your problem recorded on the current nightly builds? I don't really understand what exactly you mean :( 1) Bezier tool doesn't have a context menu, it is a known problem. 2) Selection Tool -> Right-click -> Edit Selection is a shortcut for Selection -> Show Global Selection Mask. So, basically, you should activate global selection mask, then select this mask and only after that vector tools will start working. In older versions it worked a bit differently, you could edit selections without activating the selection mask, but it conflicted with editing normal vector layers, so this behavior was removed. 3) Could you try to activate global selection mask and after that use vector tools? If the tools still don't work, than it is surely a bug. Otherwise, it is just a flaw in UIX that we should discuss together. (In reply to Dmitry Kazakov from comment #11) > Hi, Tyson! > > As could you make a video of your problem recorded on the current nightly > builds? I don't really understand what exactly you mean :( > > 1) Bezier tool doesn't have a context menu, it is a known problem. > > 2) Selection Tool -> Right-click -> Edit Selection is a shortcut for > Selection -> Show Global Selection Mask. So, basically, you should activate > global selection mask, then select this mask and only after that vector > tools will start working. In older versions it worked a bit differently, you > could edit selections without activating the selection mask, but it > conflicted with editing normal vector layers, so this behavior was removed. > > 3) Could you try to activate global selection mask and after that use vector > tools? If the tools still don't work, than it is surely a bug. Otherwise, it > is just a flaw in UIX that we should discuss together. Hi Dmitry, I can confirm it is now working with Global Selection Mask enabled. It is different from both 4.1.7 and the reference manual, so I was confused. Thank you for the explanation! So do we keep this problem for a later time? The manual has been/is being updated, so that should be fine. I think we can close the issue. |