| Summary: | When adding more than one album at a time to the playlist, songs are added in mixed-up order | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | Keywords: | usability |
| Priority: | HI | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/elisa/commit/cccafdff17a3b7dfcca97d49f8598757abb3dbda | Version Fixed In: | 19.12.0 |
| Sentry Crash Report: | |||
| Attachments: | Songs added to playlist in mixed-up order | ||
I can confirm the bug. I will work on it. Proposed fix https://phabricator.kde.org/D24271 Git commit cccafdff17a3b7dfcca97d49f8598757abb3dbda by Matthieu Gallien. Committed on 09/10/2019 at 05:02. Pushed by mgallien into branch 'master'. insert album tracks at the correct place instead of at the end Summary: inserting the tracks not at the end fix the bug detected by QAbstractItemModelTester which is really a nice tool Test Plan: new test is OK, no regressions Reviewers: #elisa, ngraham, astippich, jguidon Differential Revision: https://phabricator.kde.org/D24271 M +143 -0 autotests/mediaplaylisttest.cpp M +2 -0 autotests/mediaplaylisttest.h M +2 -2 src/mediaplaylist.cpp https://invent.kde.org/kde/elisa/commit/cccafdff17a3b7dfcca97d49f8598757abb3dbda Woohoo! |
Created attachment 119374 [details] Songs added to playlist in mixed-up order Elisa from git master. 1. Click on "Artists" on the sidebar 2. Find an artist with multiple albums 3. Click on the Play button on the artist The artist's albums are added to the playlist with the songs all mixed up, rather than in the correct order. This is 100% reproducible for me with all albums and artists when using git master. See attached screenshot.