Bug 406441

Summary:	Saved Timeline searches do not include newer items.
Product:	[Applications] digikam	Reporter:	MarcP <iwannaberich>
Component:	Searches-TimeLine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	iwannaberich, metzpinguin
Priority:	NOR
Version First Reported In:	6.1.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/655b17660e0b58b613fce6d13f41668689eb687d	Version Fixed/Implemented In:	6.1.0
Sentry Crash Report:

Description MarcP 2019-04-11 18:19:05 UTC

SUMMARY

Not sure if this is a bug or a feature request.

I noticed that saved searches in the Timeline panel are not updated when new items in that time period are added to the database.

For instance, I selected years 1990 to 1999 and saved the search as "The 90s". Later on, more pictures are added that correspond to that time period. However, when selecting that saved search, only the pictures present at the time the search was saved are displayed. Manually creating a second saved search (e.g. The 90s_2) with the same time period includes new files. Moreover, existing searches cannot be edited.

Shouldn't the search be dynamic and automatically include all files whose dates correspond to that period? Saved searches in the "Search" panel do that automatically.

STEPS TO REPRODUCE
1. Select a time period in Timeline and save that search.
2. Add new files corresponding to that time period.
3. Display the saved search.

OBSERVED RESULT
Only pictures that matched that time range at the time the search was saved are displayed.

EXPECTED RESULT
All pictures within that time range should be displayed.

SOFTWARE/OS VERSIONS
ubuntu 18.04 with Gnome
digikam-6.1.0-git-20190404T203330-qtwebkit-x86-64.appimage

Comment 1 Maik Qualmann 2019-04-11 19:17:11 UTC

We've already talked about it in another bugreport that after adding new items, the date albums will not be updated until after 30 seconds because the process is very computationally intensive. Originally it was even 60 seconds, I have already lowered the time. So only after 30 seconds will your timeline search show the new items.

Maik

Comment 2 MarcP 2019-04-11 19:25:44 UTC

I think you are referring to Bug #398810, which deal with the Dates panel, not the Timeline panel.

Right now I have two searches for the 1990-1999 range. One of them was created last year, and the other one earlier today. The first has 779 items and the second one 906. I am convinced those numbers are static unless I create a new saved search.

Comment 3 Maik Qualmann 2019-04-11 20:40:29 UTC

Only dates in the search are stored. One would now have to compare the two searches in the database in the "Searches" table to find the cause.

Maik

Comment 4 Maik Qualmann 2019-04-11 20:44:32 UTC

Incidentally, the 30 second update interval also applies to the timeline search, it is also a date album.

Maik

Comment 5 Maik Qualmann 2019-04-11 20:53:15 UTC

Correction, the timeline search is unaffected by the 30 seconds...

Maik

Comment 6 Maik Qualmann 2019-04-12 05:53:36 UTC

I can not reproduce a problem. I do not have a timeline search that is one year old. With a new search and when I add images that fall into the period, these are also displayed by the timeline search. Can you please compare your two searches again exactly, if they actually contain the same and complete date range?

Maik

Comment 7 MarcP 2019-04-12 22:10:04 UTC

Hi again,

I checked the database to compare the difference between the two searches. Apparently, each individual date for the files in that period is saved in a list, so only the files matching those dates will be displayed in the saved search. This is why an old search cannot list newer files.

The queries are quite long, so I used pastebin:

The one I created a year ago: https://pastebin.com/amnCxvQZ
The one I created yesterday: https://pastebin.com/TmipVD0Z

If you compare the two texts, you'll see that the second one includes more dates compared to he first one.

Comment 8 Maik Qualmann 2019-04-13 08:19:36 UTC

Ok, on days when there are no image are excluded from the stored date range. I will look for a solution.

Maik

Comment 9 MarcP 2019-04-13 16:14:39 UTC

Thanks. It's not a big deal, though.

Comment 10 Maik Qualmann 2019-04-13 20:32:23 UTC

Git commit 655b17660e0b58b613fce6d13f41668689eb687d by Maik Qualmann.
Committed on 13/04/2019 at 20:31.
Pushed by mqualmann into branch 'master'.

select with shift key a timeline range
FIXED-IN: 6.1.0

M  +2    -1    NEWS
M  +27   -8    core/app/date/timelinewidget.cpp

https://commits.kde.org/digikam/655b17660e0b58b613fce6d13f41668689eb687d

Comment 11 Maik Qualmann 2019-04-13 20:38:11 UTC

Note: The timeline widget allows single / existing selection with the control key. Now you have to create a new search whose end date is selected with the shift key. This selection with shift key is now a range selection from the start date to the end date.

Maik